Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release notes 0.280 #19143

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Release notes 0.280 #19143

merged 1 commit into from
Mar 23, 2023

Conversation

rohanpednekar
Copy link
Contributor

@rohanpednekar rohanpednekar commented Mar 6, 2023 •
edited

Add release notes for 0.280

Detailed description at #19110 (comment)

@rohanpednekar rohanpednekar requested a review from a team as a code owner March 6, 2023 21:16
@rohanpednekar rohanpednekar mentioned this pull request Mar 6, 2023
Closed
@jainxrohit
Copy link
Contributor

Clean up the PR description. Please check other similar release notes.

@rohanpednekar
Copy link
Contributor Author

rohanpednekar commented Mar 9, 2023 •
edited

Clean up the PR description. Please check other similar release notes.

@wanglinsong already created #19110 PR for the same release notes and because of that, i am failing to create the usual long description here that we create with a script. We will streamline this in the next release notes.

@jainxrohit
Copy link
Contributor

squash commits.

@rohanpednekar
Copy link
Contributor Author

squash commits.

Done! Thanks for the review.

@jainxrohit
Copy link
Contributor

commit message has typo.

@rohanpednekar rohanpednekar force-pushed the release-notes-0.280 branch 2 times, most recently from a42196c to 987e790 Compare March 10, 2023 17:42
jainxrohit
jainxrohit approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@jainxrohit jainxrohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanglinsong
Copy link
Member

wanglinsong commented Mar 14, 2023 •
edited

Pinging @pranjalssh

@wanglinsong
Copy link
Member

@yingsu00 can you merge this?

yingsu00
yingsu00 requested changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@yingsu00 yingsu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdcmeehan @rschlussel Could you please also review the changes and see if the wordings are authentic English? Thank you!

presto-docs/src/main/sphinx/release/release-0.280.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.280.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.280.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.280.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.280.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.280.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.280.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.280.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.280.rst Outdated Show resolved Hide resolved
yingsu00
yingsu00 requested changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@yingsu00 yingsu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohanpednekar Also I don't see the release notes mentioned as missing #19110?
Fo example, these definitely need release notes. Can you please follow up with the committers and authors?
[native] Remove deprecated.legacy-date-timestamp-to-varchar-coercion … #19010 (Merged by: Amit Dutta)
Introduce new Keyword FETCH FIRST N ROWS ONLY in Presto Query #18968 (Merged by: Rebecca Schlussel)

@rohanpednekar rohanpednekar mentioned this pull request Mar 17, 2023
Merged
@rohanpednekar
Copy link
Contributor Author

@rohanpednekar Also I don't see the release notes mentioned as missing #19110? Fo example, these definitely need release notes. Can you please follow up with the committers and authors? [native] Remove deprecated.legacy-date-timestamp-to-varchar-coercion … #19010 (Merged by: Amit Dutta) Introduce new Keyword FETCH FIRST N ROWS ONLY in Presto Query #18968 (Merged by: Rebecca Schlussel)

I have tried to add release notes about these features, please check.

yingsu00
yingsu00 reviewed Mar 21, 2023
View reviewed changes
Copy link
Contributor

@yingsu00 yingsu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't see the release notes for #19010
@amitkdutta Can you please confirm if the following looks good?
@rohanpednekar Can you please add it to the last line in the "General" section?

Remove the deprecated.legacy-date-timestamp-to-varchar-coercion configuration property, which was used for Raptor to Presto migration.

presto-docs/src/main/sphinx/release/release-0.280.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.280.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.280.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/release/release-0.280.rst Outdated Show resolved Hide resolved
@rohanpednekar
Update release-0.280.rst
cfe2c96 
Update release-0.280.rst

Update release-0.280.rst

Update release-0.280.rst

Update release-0.280.rst

Update release-0.280.rst

Updateed release-0.280.rst

Update release-0.280.rst
@rohanpednekar
Copy link
Contributor Author

I still don't see the release notes for #19010 @amitkdutta Can you please confirm if the following looks good? @rohanpednekar Can you please add it to the last line in the "General" section?

Remove the deprecated.legacy-date-timestamp-to-varchar-coercion configuration property, which was used for Raptor to Presto migration.

Done!

@amitkdutta
Copy link
Contributor

I still don't see the release notes for #19010 @amitkdutta Can you please confirm if the following looks good? @rohanpednekar Can you please add it to the last line in the "General" section?
Remove the deprecated.legacy-date-timestamp-to-varchar-coercion configuration property, which was used for Raptor to Presto migration.

Done!

@rohanpednekar Thanks. It looks good. I also updated the tile of the PR

@yingsu00 yingsu00 merged commit 6056cf3 into prestodb:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanglinsong wanglinsong wanglinsong approved these changes

@yingsu00 yingsu00 yingsu00 approved these changes

@rschlussel rschlussel rschlussel approved these changes

@jainxrohit jainxrohit jainxrohit approved these changes

@pranjalssh pranjalssh Awaiting requested review from pranjalssh pranjalssh is a code owner automatically assigned from prestodb/committers

@feilong-liu feilong-liu Awaiting requested review from feilong-liu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rohanpednekar @jainxrohit @wanglinsong @amitkdutta @yingsu00 @rschlussel @feilong-liu