New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the memory accounting for different BatchStreamReaders #19156

Draft

MnO2 wants to merge 1 commit into prestodb:master from MnO2:account-batch-stream-readers

Contributor

MnO2 commented Mar 8, 2023

Test plan - (Please fill in how you tested your changes)

Inspired by this Trino's memory accounting fix: Fix worker OOM trinodb/trino#9949
It seems that we have a few places in our Orc reader where the setBytes are not passed with the correct retained bytes. They are only passed with the individual allocated array but not the total retained size.
This diff corrects the accounting on them.

== NO RELEASE NOTE ==

MnO2 force-pushed the account-batch-stream-readers branch 2 times, most recently from b659166 to 7e8e58d Compare

March 13, 2023 16:22


          Improve the memory accounting for different BatchStreamReaders

03cdc8c

MnO2 force-pushed the account-batch-stream-readers branch from 7e8e58d to 03cdc8c Compare

March 14, 2023 14:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment