add merge_tdigest function #20520
Merged
add merge_tdigest function #20520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ampampamp
commented
Aug 8, 2023
presto-main/src/main/java/com/facebook/presto/operator/scalar/TDigestFunctions.java
Outdated
Show resolved
Hide resolved
|
CC: @steveburnett to review docs change |
steveburnett
approved these changes
Aug 9, 2023
ampampamp
force-pushed
the
ampampamp_arraymerge
branch
from
62471f6
to
901475c
Compare
|
Updated to include suggestion from @tdcmeehan. |
|
I need to address the failing checks, but @tdcmeehan - @jainavi17 had suggested the name |
|
Agreed on the naming |
ampampamp
force-pushed
the
ampampamp_arraymerge
branch
from
901475c
to
2d0ad86
Compare
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 459a8b0...2d0ad86.
|
|
Updated function name to |
tdcmeehan
approved these changes
Aug 11, 2023
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a scalar function to merge T-digests from an input array.
Motivation and Context
Existing issue: #18402
The aggregate function
MERGEhas existed for digests, but never the scalar equivalent.(previously opened in #20510 but closed due to rebase error)
Impact
No impact, net-new function.
Test Plan
Added unit tests.
Built with:
Release Notes
Please follow release notes guidelines and fill in the release notes below.
== RELEASE NOTES ==
General Changes
MERGE_TDIGEST.MERGE_TDIGEST(CAST(ARRAY[digest1, digest2, ...] AS ARRAY(TDIGEST(DOUBLE))))