Flat hash aggregation #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return binder.bind(inputs); | ||
| if (inputs.isEmpty()) { | ||
| return aggregation(function, -1); | ||
| } else { |
Add back vectorized aggergation operation
| slice.setByte(index, slice.getByte(index) | bitMask); | ||
| } | ||
|
|
||
| public void setNotNull(Slice slice, int offset, int field) |
There was a problem hiding this comment.
I think it's a bit weird that a field can be marked as null/notnull independently from setting its value. Calling setLong/Double/etc should make the field non-null. Clearly, doing this on every call to those methods would impact performance, so I don't know if there's a better approach.
| } | ||
|
|
||
| return PageIterators.singletonIterator(new Page(blocks)); | ||
| } | ||
|
|
||
| @SuppressWarnings("rawtypes") | ||
| public static Aggregator createAggregator(AggregationFunctionDefinition functionDefinition, Step step) |
There was a problem hiding this comment.
Mark this @VisibleForTesting and maybe make it package private
|
looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.