Support persistent CTE's #20887
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.facebook.presto.sql.planner.optimizations; | ||
|
|
||
| import com.facebook.presto.common.type.RowType; | ||
| import com.facebook.presto.common.type.VarcharType; | ||
| import com.facebook.presto.common.type.Varchars; | ||
| import com.facebook.presto.spi.PrestoException; | ||
| import com.facebook.presto.spi.relation.VariableReferenceExpression; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| import static com.facebook.presto.spi.StandardErrorCode.GENERIC_INTERNAL_ERROR; | ||
|
|
||
| public class CteUtils | ||
| { | ||
| private CteUtils() | ||
| { | ||
| } | ||
|
|
||
| // Determines whether the CTE can be materialized. | ||
| public static boolean isCteMaterializable(List<VariableReferenceExpression> outputVariables) | ||
| { | ||
| return outputVariables.stream().anyMatch(CteUtils::isVariableMaterializable) | ||
| && outputVariables.stream() | ||
| .allMatch(variableReferenceExpression -> { | ||
| if (Varchars.isVarcharType(variableReferenceExpression.getType())) { | ||
| return isSupportedVarcharType((VarcharType) variableReferenceExpression.getType()); | ||
| } | ||
| return true; | ||
| }); | ||
| } | ||
|
|
||
| /* | ||
| Fetches the index of the first variable that can be materialized. | ||
| ToDo: Implement usage of NDV (number of distinct values) statistics to identify the best partitioning variable, | ||
| as temporary tables are bucketed. | ||
| */ | ||
| public static Integer getCtePartitionIndex(List<VariableReferenceExpression> outputVariables) | ||
| { | ||
| for (int i = 0; i < outputVariables.size(); i++) { | ||
| if (isVariableMaterializable(outputVariables.get(i))) { | ||
| return i; | ||
| } | ||
| } | ||
| throw new PrestoException(GENERIC_INTERNAL_ERROR, "No Partitioning index found"); | ||
| } | ||
|
|
||
| /* | ||
| Currently, Hive bucketing does not support the Presto type 'ROW'. | ||
| */ | ||
| public static boolean isVariableMaterializable(VariableReferenceExpression var) | ||
| { | ||
| return !(var.getType() instanceof RowType); | ||
|
There was a problem hiding this comment. what about other types not supported by Hive such as TIME? There was a problem hiding this comment. also, can we add tests for these types? There was a problem hiding this comment. The recommended table format is Pagefile which doesn't require translation to hivetypes. Also, there special handling already that uses the format pagefile for these types that are not supported by hive. There was a problem hiding this comment. can you add some tests like this: There was a problem hiding this comment. Added a test based on ttwithtz, thanks |
||
| } | ||
|
|
||
| /* | ||
| While Presto supports Varchar of length 0 (as discussed in https://github.com/trinodb/trino/issues/1136), | ||
| Hive does not support this. | ||
| */ | ||
| private static boolean isSupportedVarcharType(VarcharType varcharType) | ||
| { | ||
| return (varcharType.isUnbounded() || varcharType.getLengthSafe() != 0); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NestedCteStack is responsible for managing the scope of the CTE
cteStack keeps track of the current CTEs that are accessible outside this scope.
The rawCtePathMap holds the localCtes along with their respective scopes, keeping them updated.