Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Helm Charts to Installation docs #21812

Merged

Conversation

steveburnett
Copy link
Contributor

Description

Add linking page for Presto Helm Charts to the Installation docs.

Motivation and Context

Helm Charts are an active interest topic for deploying Presto. Mentioning Helm Charts as an available option in the Installation documentation improves the visibility of Presto Helm Charts to users of the Presto documentation.

Impact

Documentation.

Test Plan

Local build of documentation, verified that the new page was built, that the link in the new page links correctly to the Presto Helm Chart repo, and that the new page was added to the Installation table of contents.

Screenshots of local doc build:
Screenshot 2024-01-29 at 2 35 54 PM
Screenshot 2024-01-29 at 2 35 59 PM

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Added Helm Charts to Installation documentation. 

@steveburnett steveburnett self-assigned this Jan 29, 2024
@steveburnett steveburnett requested a review from a team as a code owner January 29, 2024 19:41
@github-actions github-actions bot added the docs label Jan 29, 2024
@tdcmeehan
Copy link
Contributor

CC: @@dnskr

@tdcmeehan tdcmeehan self-assigned this Jan 29, 2024
@dnskr
Copy link
Contributor

dnskr commented Jan 29, 2024

@steveburnett Great idea to add the Helm chart to the documentation!
The PR is a good start to make people aware of its existence and increase the chart adoption.

@tdcmeehan tdcmeehan merged commit b5cb9b2 into prestodb:master Jan 30, 2024
57 checks passed
@wanglinsong wanglinsong mentioned this pull request Feb 12, 2024
64 tasks
@steveburnett steveburnett deleted the steveburnett-deploy-helm-charts branch April 16, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants