New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for new JDBC connector Snowflake #21842
base: master
Are you sure you want to change the base?
Conversation
As this draft develops, please add documentation by adding a new file about this connector to https://github.com/prestodb/presto/tree/master/presto-docs/src/main/sphinx/connector. |
321ad6c
to
d5f27de
Compare
3433d12
to
1ed0422
Compare
1ed0422
to
5eab0f3
Compare
Codenotify: Notifying subscribers in CODENOTIFY files for diff d4bdf97...1547465.
|
5eab0f3
to
69526a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the documentation! I made a few suggestions for clarity and style, and tried to explain my reasoning. Let me know if you have any concerns about my suggestions and we'll figure out answers together.
``case-insensitive-name-matching`` Match dataset and table names case-insensitively. ``false`` | ||
|
||
``case-insensitive-name-matching.cache-ttl`` Duration for which remote dataset and table names will be | ||
cached. Set to ``0ms`` to disable the cache. ``1m`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a standard set of abbreviations for measurements of time in this context? This reads to me as both milliseconds and minutes are acceptable values. I searched but didn't find anything quickly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steveburnett - Both units milliseconds and minutes are supported.
To add the new documentation page to the Connectors index page in the documentation, in addition to creating the new .rst page in the /connector directory, you must also edit the connectors index page https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/connector.rst |
69526a5
to
51b0a7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (docs)
Pulled updated branch, new local build of docs. Everything looks good, thanks!
The Snowflake Connector link appears on the Connectors index page in the local build.
51b0a7d
to
1547465
Compare
This is an important connect for Presto as this will give us ability handle snowflake usecases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A need of the hour connector for presto, huge value for community
@dmariamgeorge We need following before it to get merged
|
Description
Snowflake database is a cloud-hosted relational database that is used to build data warehouses and combines the functions of traditional databases with new capabilities. This PR implements support for the Snowflake connector in Presto by introducing a new module presto-snowflake.
Motivation and Context
Adding support to the Snowflake connector allows querying and creating tables in an external Snowflake database through Presto. This can be used to join data between different systems like Snowflake and Hive, or between two different Snowflake accounts.
Impact
Introduces a new module presto-snowflake. Allows users to connect to external Snowflake database and query through Presto. Following statements that are checked are supported by the Snowflake connector in Presto:
Addresses the issue #21843.
Test Plan
Configured the Snowflake connector, by creating a catalog properties file in etc/catalog named snowflake.properties, to mount the Snowflake connector as the snowflake catalog. Tested the following SQL statements:
queries.txt
Contributor checklist
Release Notes