Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TestingHiveStorageFormat #22519

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Remove TestingHiveStorageFormat #22519

merged 1 commit into from
Apr 22, 2024

Conversation

TishyaaChaudhry
Copy link
Contributor

@TishyaaChaudhry TishyaaChaudhry commented Apr 13, 2024 •
edited

Description

Remove TestHiveIntegrationSmokeTest.TestingHiveStorageFormat as it wraps a few fields that don't need to be wrapped

Motivation and Context

Fixes #22476

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@TishyaaChaudhry TishyaaChaudhry marked this pull request as ready for review April 13, 2024 19:18
@TishyaaChaudhry TishyaaChaudhry requested a review from a team as a code owner April 13, 2024 19:18
@elharo elharo requested a review from tdcmeehan April 15, 2024 10:58
@tdcmeehan
Copy link
Contributor

Small nit, reword commit

Remove TestingHiveStorageFormat

@tdcmeehan tdcmeehan self-assigned this Apr 16, 2024
@TishyaaChaudhry TishyaaChaudhry force-pushed the Remove-TestingHiveStorageFormat-22476 branch from 93655cb to 164f732 Compare April 16, 2024 19:16
@TishyaaChaudhry
Copy link
Contributor Author

@tdcmeehan Sorry about that. I have fixed it. Should I also merge master to my PR?

@tdcmeehan
Copy link
Contributor

Thank you for your contribution!

@tdcmeehan tdcmeehan merged commit 6d052a3 into prestodb:master Apr 22, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elharo elharo elharo approved these changes

@tdcmeehan tdcmeehan tdcmeehan approved these changes

@mtafadar mtafadar mtafadar approved these changes

@presto-oss presto-oss Awaiting requested review from presto-oss presto-oss is a code owner automatically assigned from prestodb/committers

Assignees

@tdcmeehan tdcmeehan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove TestingHiveStorageFormat
4 participants
@TishyaaChaudhry @tdcmeehan @elharo @mtafadar