Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer JDK's StandardCharsets #22677

Merged
merged 1 commit into from May 13, 2024
Merged

Prefer JDK's StandardCharsets #22677

merged 1 commit into from May 13, 2024

Conversation

elharo
Copy link
Contributor

@elharo elharo commented May 6, 2024

Description

Replace internal UTF-8 constant with JDK StandardCharsets.UTF_8

Motivation and Context

Modernization. This hasn't been needed since Java 6.

Impact

StringUtils.UTF_8 is deleted.

Test Plan

CI

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTES ==

@elharo elharo changed the title Prefer Java 8 StandardCharsets Prefer JDK's StandardCharsets May 6, 2024
@elharo elharo requested a review from tdcmeehan May 6, 2024 14:47
@steveburnett
Copy link
Contributor

Suggest revising the release note entry following the release notes guidelines. Maybe like this:

== RELEASE NOTES ==

General Changes
* Replace StringUtils.UTF_8 with StandardCharsets.UTF_8 :pr:`22677`

@elharo
Copy link
Contributor Author

elharo commented May 6, 2024

Replace StringUtils.UTF_8 with StandardCharsets.UTF_8 :pr:22677

is the implementation change. The public API change is that StringUtils.UTF_8 is defunct.

@elharo elharo marked this pull request as ready for review May 6, 2024 15:43
@elharo elharo requested a review from a team as a code owner May 6, 2024 15:43
@elharo elharo requested a review from presto-oss May 6, 2024 15:43
@steveburnett
Copy link
Contributor

steveburnett commented May 6, 2024

Thanks for the clarification! Maybe you can find an accurate rephrasing that follows the Order of changes in the Release Notes Guidelines.

[edit to add] Nice work on the rephrasing, thanks!

@tdcmeehan
Copy link
Contributor

There should be no user-visible change, so release note not necessary.

@tdcmeehan tdcmeehan self-assigned this May 6, 2024
@elharo
Copy link
Contributor Author

elharo commented May 6, 2024

Could swear somewhere it said something about API changes, but in any case fixed. No more release notes here. PTAL

@tdcmeehan tdcmeehan merged commit a9bc7c3 into master May 13, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants