Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native] Remove memory related counters #22721

Merged
merged 1 commit into from May 12, 2024

Conversation

tanjialiang
Copy link
Contributor

Remove memory and cache counter definitions from presto native. They are migrated to velox.

== NO RELEASE NOTE ==

@tanjialiang tanjialiang requested a review from a team as a code owner May 11, 2024 17:57
@jaystarshot
Copy link
Member

Can we add release notes for this? This might break a lot of existing dashboards

Copy link
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@tanjialiang
Copy link
Contributor Author

Can we add release notes for this? This might break a lot of existing dashboards

Thanks! I've added release notes in the PR that actually removed the reporting. This PR is just cleaning up the metrics declarations, not any behavior changes for reporting. Please take a look at this PR for release notes #22720

@tanjialiang tanjialiang merged commit 00655a0 into prestodb:master May 12, 2024
58 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants