Enhance FunctionCallRewriter #22785
Merged
Enhance FunctionCallRewriter #22785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gggrace14
force-pushed
the
newfunctionbase
branch
from
8b94f06
to
a476e3c
Compare
arhimondr
reviewed
May 22, 2024
presto-verifier/src/main/java/com/facebook/presto/verifier/framework/VerifierConfig.java
Outdated
Show resolved
Hide resolved
presto-verifier/src/main/java/com/facebook/presto/verifier/framework/VerifierConfig.java
Outdated
Show resolved
Hide resolved
presto-verifier/src/main/java/com/facebook/presto/verifier/rewrite/QueryRewriter.java
Outdated
Show resolved
Hide resolved
presto-verifier/src/test/java/com/facebook/presto/verifier/rewrite/TestQueryRewriter.java
Outdated
Show resolved
Hide resolved
presto-verifier/src/main/java/com/facebook/presto/verifier/rewrite/FunctionCallRewriter.java
Outdated
Show resolved
Hide resolved
presto-verifier/src/main/java/com/facebook/presto/verifier/rewrite/FunctionCallRewriter.java
Outdated
Show resolved
Hide resolved
presto-verifier/src/main/java/com/facebook/presto/verifier/rewrite/FunctionCallRewriter.java
Show resolved
Hide resolved
presto-verifier/src/main/java/com/facebook/presto/verifier/rewrite/FunctionCallRewriter.java
Outdated
Show resolved
Hide resolved
presto-verifier/src/main/java/com/facebook/presto/verifier/rewrite/FunctionCallRewriter.java
Outdated
Show resolved
Hide resolved
presto-verifier/src/main/java/com/facebook/presto/verifier/rewrite/FunctionCallRewriter.java
Show resolved
Hide resolved
gggrace14
force-pushed
the
newfunctionbase
branch
3 times, most recently
from
5cd47ef
to
f85816e
Compare
Enhance FunctionCallRewriter to support function substitution for multi-signature functions. Change to use Multimap to support one function name mapped to multiple function substitutes. Select the first function substitute where the original function declaration matches. Inherit the filter field and window fields of the original function by the aggregate or window functions in the substitute. Introduce the FunctionAndTypeManager to FunctionCallRewriter to identify aggregate and window functions.
arhimondr
previously approved these changes
May 24, 2024
gggrace14
force-pushed
the
newfunctionbase
branch
from
f85816e
to
e55bfe2
Compare
arhimondr
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance FunctionCallRewriter to support function substitution for multi-signature functions. Change to use Multimap to support one function name mapped to multiple function substitutes. Select the first function substitute where the original function declaration matches.
Inherit the filter field and window fields of the original function by the aggregate or window functions in the substitute. Introduce the FunctionAndTypeManager to FunctionCallRewriter to identify aggregate and window functions.