[verifier] Add 'control_query_utf8' and 'test_query_utf8' columns. #23099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spershin
force-pushed
the
NewVerifierQueryColumns
branch
3 times, most recently
from
5bb3421
to
1216dd3
Compare
spershin
force-pushed
the
NewVerifierQueryColumns
branch
from
1216dd3
to
dbf68e5
Compare
steveburnett
previously approved these changes
Jul 1, 2024
spershin
force-pushed
the
NewVerifierQueryColumns
branch
from
dbf68e5
to
b5c410a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add 'control_query_utf8' and 'test_query_utf8' columns to the verifier query table.
Motivation and Context
We realized that existing 'control_query' and 'test_query' columns are of latin1 format, which
results is some utf8 characters loss.
Direct conversion of the table columns is failing due to the existing data, so we have come
up with a workaround via the additional temporary columns.
At some point we can remove either the new columns or the old ones and keep the new ones.
The new columns are used if not null, otherwise the old ones are used.
Test Plan
Made a custom build and tested it on a altered table.
Works like a charm!