Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use airbase flags for checkstyle defaults #6866

Merged
merged 1 commit into from Dec 15, 2016
Merged

Use airbase flags for checkstyle defaults #6866

merged 1 commit into from Dec 15, 2016

Conversation

electrum
Copy link
Contributor

No description provided.

@ArturGajowy
Copy link
Contributor

I'm not sure how, but I believe this works :) LGTM as long as you've tested that pass -Dair.check.skip-all=true disables checkstyle analysis and that the analysis runs otherwise

@electrum
Copy link
Contributor Author

@ArturGajowy Yep, I verified this

@electrum
Copy link
Contributor Author

$ mvn validate -pl .
...
[INFO] --- maven-checkstyle-plugin:2.17:check (default) @ presto-root ---
[INFO] Starting audit...
Audit done.
[INFO] 

$ mvn validate -pl . -Dair.check.skip-all
...
[INFO] --- maven-checkstyle-plugin:2.17:check (default) @ presto-root ---
[INFO] 

$ mvn validate -pl . -Dair.check.skip-basic
[INFO] --- maven-checkstyle-plugin:2.17:check (default) @ presto-root ---
[INFO] 

@electrum electrum closed this Dec 15, 2016
@electrum electrum deleted the checkstyle branch December 15, 2016 22:53
@electrum electrum merged commit 3fa71b6 into prestodb:master Dec 15, 2016
@electrum
Copy link
Contributor Author

Another trick is you can run Maven with -X and it will show you the plugin config:

[DEBUG] -----------------------------------------------------------------------
[DEBUG] Goal:          org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (default)
[DEBUG] Style:         Regular
[DEBUG] Configuration: <?xml version="1.0" encoding="UTF-8"?>
<configuration>
...
  <skip default-value="false">false</skip>
...
</configuration>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants