Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Iceberg samples #5

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

ZacBlanco
Copy link

No description provided.

@ZacBlanco
Copy link
Author

From the original thread from @aaneja:

Some questions I had -
What would be the schema for the $samples table ? Would there be any extra columns besides the ones from the underlying table

The schema should exactly map to the real table. Any updates to the real table's schema would also happen on the sample table.

Would we store some metadata for the $samples table that could be used to identify -
What table sampling method was used to seed the sample
When was the sample last updated w.r.t to the changelog

This was not mentioned in the RFC, but our prototype implementation included this info. We stored it in the iceberg table properties. I will add this to the RFC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant