Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip RemoveRedundantTableScanPredicate if predicate doesn't change #10985

Merged
merged 3 commits into from
Feb 10, 2022
Merged

Skip RemoveRedundantTableScanPredicate if predicate doesn't change #10985

merged 3 commits into from
Feb 10, 2022

Conversation

sopel39
Copy link
Member

@sopel39 sopel39 commented Feb 8, 2022

Fixes #10532

@cla-bot cla-bot bot added the cla-signed label Feb 8, 2022
This was referenced Feb 8, 2022
Closed
Closed
findepi
findepi reviewed Feb 9, 2022
View reviewed changes
Copy link
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me re-review after commit boundaries

core/trino-main/src/main/java/io/trino/sql/planner/PlanOptimizers.java Outdated Show resolved Hide resolved
...ain/src/main/java/io/trino/sql/planner/iterative/rule/RemoveRedundantTableScanPredicate.java Show resolved Hide resolved
@sopel39
Rename RemoveRedundantPredicateAboveTableScan
96a164b 
Rename RemoveRedundantPredicateAboveTableScan to RemoveRedundantPredicateAboveTableScan
@sopel39 sopel39 merged commit 62df13a into trinodb:master Feb 10, 2022
@sopel39 sopel39 deleted the ks/skip_remove branch February 10, 2022 10:15
@sopel39 sopel39 mentioned this pull request Feb 10, 2022
Closed
@github-actions github-actions bot added this to the 371 milestone Feb 10, 2022
@mosabua mosabua mentioned this pull request Feb 10, 2022
Merged
@martint martint mentioned this pull request Feb 11, 2022
Closed
@findepi findepi mentioned this pull request Mar 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findepi findepi findepi approved these changes

@martint martint Awaiting requested review from martint

Assignees
No one assigned
Labels
cla-signed
Milestone
371
Development

Successfully merging this pull request may close these issues.

planning infinite in some cases
3 participants
@sopel39 @martint @findepi