Wait for running queries issued during grace period to finish #2648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dain
requested changes
Jan 29, 2020
| // wait for another grace period for all task states to be observed by the coordinator | ||
| sleepUninterruptibly(gracePeriod.toMillis(), MILLISECONDS); | ||
| // wait for another grace period for all task states and shutting down state to be observed by the coordinator | ||
| sleepUninterruptibly(gracePeriod.toMillis(), MILLISECONDS); |
There was a problem hiding this comment.
We need to wait at least once.... actually, I maybe we should wait first, and then shutdown once all tasks exit.
sopel39
force-pushed
the
ks/graceful_shutting_down
branch
from
c177188
to
19a4da4
Compare
|
ac |
sopel39
force-pushed
the
ks/graceful_shutting_down
branch
from
19a4da4
to
8b8d481
Compare
dain
approved these changes
Feb 20, 2020
sopel39
force-pushed
the
ks/graceful_shutting_down
branch
from
8b8d481
to
d19bc9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #2621
Fixes one race condition between worker shutting down and issuing new queries by coordinator