Allow setting identity for insecure connections with passwordless basic auth #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dain
force-pushed
the
http-basic-auth
branch
3 times, most recently
from
4edc430
to
b200774
Compare
|
got an example connection string or paragraph about the behaviour? from the sounds of it , it creates security flaw allowing someone to impersonate someone else without their credentials |
|
This is only when running in insecure mode (via http), which is useful for testing and development. For secure mode, https and proper authentication (via password, JWT, Kerberos or certificates) is required. Presto will perform authorization and impersonation checks only after the identity has been verified. |
electrum
approved these changes
Feb 2, 2020
presto-main/src/main/java/io/prestosql/server/security/BasicAuthCredentials.java
Show resolved
Hide resolved
For insecure connections, allow HTTP basic auth with no password for setting identity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.