Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate session catalog in role commands #2768

Merged
merged 1 commit into from Feb 12, 2020
Merged

Validate session catalog in role commands #2768

merged 1 commit into from Feb 12, 2020

Conversation

electrum
Copy link
Member

@electrum electrum commented Feb 8, 2020 •
edited

Fixes #2767

@cla-bot cla-bot bot added the cla-signed label Feb 8, 2020
kokosing
kokosing reviewed Feb 8, 2020
View reviewed changes
Copy link
Member

@kokosing kokosing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general looks good

presto-main/src/test/java/io/prestosql/execution/TestSetRoleTask.java Show resolved Hide resolved
@electrum electrum force-pushed the setrole branch 3 times, most recently from 0ee7e99 to 00a09ab Compare February 9, 2020 05:47
kokosing
kokosing approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@kokosing kokosing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

% github actions failure

@electrum electrum merged commit 24a83f3 into trinodb:master Feb 12, 2020
@electrum electrum deleted the setrole branch February 12, 2020 01:41
@electrum electrum mentioned this pull request Feb 15, 2020
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kokosing kokosing kokosing approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

USE fails when in an invalid catalog when a role for that catalog is set
2 participants
@electrum @kokosing