Record filters and masks #3183
Merged
Record filters and masks #3183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
force-pushed
the
record-filters-masks
branch
from
f4554f3
to
1d1e0b6
Compare
martint
force-pushed
the
record-filters-masks
branch
from
1d1e0b6
to
24c0e4c
Compare
kokosing
reviewed
Mar 21, 2020
presto-main/src/main/java/io/prestosql/sql/analyzer/Analysis.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/io/prestosql/sql/analyzer/Analysis.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/io/prestosql/dispatcher/FailedDispatchQuery.java
Show resolved
Hide resolved
| @@ -226,6 +226,7 @@ private static QueryInfo immediateFailureQueryInfo( | |||
| ImmutableList.of(), | |||
| ImmutableSet.of(), | |||
There was a problem hiding this comment.
There are missing information about accessed:
- procedures (must have)
- functions (must have)
- DDL queries
- set session
- SHOW queries
- query checks
All these surely should go as separate pull requests.
There was a problem hiding this comment.
DDL queries can be inferred from the query type + user + target table. Session properties can be inferred from the session properties in the query + user. Functions and procedures can be added, but I'll do it in a separate PR.
martint
force-pushed
the
record-filters-masks
branch
from
24c0e4c
to
85faf5e
Compare
|
Updated |
kokosing
approved these changes
Mar 24, 2020
presto-main/src/main/java/io/prestosql/sql/analyzer/Analysis.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/io/prestosql/sql/analyzer/Analysis.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/io/prestosql/sql/analyzer/RelationId.java
Outdated
Show resolved
Hide resolved
presto-spi/src/main/java/io/prestosql/spi/eventlistener/TableInfo.java
Outdated
Show resolved
Hide resolved
presto-spi/src/main/java/io/prestosql/spi/eventlistener/TableInfo.java
Outdated
Show resolved
Hide resolved
presto-tests/src/test/java/io/prestosql/execution/TestEventListener.java
Show resolved
Hide resolved
martint
force-pushed
the
record-filters-masks
branch
3 times, most recently
from
03180de
to
01a27a4
Compare
martint
force-pushed
the
record-filters-masks
branch
from
01a27a4
to
69063bd
Compare
martint
force-pushed
the
record-filters-masks
branch
2 times, most recently
from
32ff774
to
db2dd44
Compare
It adds a field to the query metadata event with the following structure:
"tables": [
{
"catalog": "...",
"schema": "...",
"table": "...",
"authorization": "...",
"filters": [ "...", ... ]
"columns": [
{
"column": "..."
"masks": [ "...", ...]
},
...
]
},
...
]
martint
force-pushed
the
record-filters-masks
branch
from
db2dd44
to
16c0355
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new field to query metadata section in the query completion event with the following structure: