Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix numeric casts #328

Merged
merged 2 commits into from
Feb 27, 2019
Merged

Fix numeric casts #328

merged 2 commits into from
Feb 27, 2019

Conversation

findepi
Copy link
Member

@findepi findepi commented Feb 26, 2019

No description provided.

@findepi findepi force-pushed the findepi/master/fix-numeric-casts-bcf670 branch from e47839d to 57135d6 Compare February 26, 2019 14:31
@cla-bot cla-bot bot added the cla-signed label Feb 26, 2019
martint
martint approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@martint martint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit title is too vague. In fact, nothing’s being fixed. It’s just making casts strict. Maybe say that instead?

presto-parser/src/main/java/io/prestosql/sql/SqlFormatter.java
@@ -683,7 +683,6 @@ protected Void visitShowStats(ShowStats node, Integer context)
{
builder.append("SHOW STATS FOR ");
process(node.getRelation(), 0);
builder.append("");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i hoped it will pass unnoticed

@findepi findepi force-pushed the findepi/master/fix-numeric-casts-bcf670 branch from 57135d6 to 8550f18 Compare February 26, 2019 16:39
@findepi
Copy link
Member Author

findepi commented Feb 26, 2019

@martint thanks, AC

@findepi findepi force-pushed the findepi/master/fix-numeric-casts-bcf670 branch from 51fb949 to d2d8cb6 Compare February 26, 2019 21:39
@findepi
Make numeric casts strict
5fbf5ab 
This replace a number of narrowing numeric casts with checked
equivalents.
@findepi findepi force-pushed the findepi/master/fix-numeric-casts-bcf670 branch from d2d8cb6 to 5fbf5ab Compare February 27, 2019 08:03
@findepi findepi merged commit 7d0f46c into trinodb:master Feb 27, 2019
@findepi findepi deleted the findepi/master/fix-numeric-casts-bcf670 branch February 27, 2019 20:40
@findepi findepi added this to the 305 milestone Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martint martint martint approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
305
Development

Successfully merging this pull request may close these issues.
2 participants
@findepi @martint