Ignore ES indexes without mappings #4535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
reviewed
Jul 22, 2020
presto-elasticsearch/src/main/java/io/prestosql/elasticsearch/ElasticsearchMetadata.java
Outdated
Show resolved
Hide resolved
findepi
reviewed
Jul 24, 2020
presto-elasticsearch/src/main/java/io/prestosql/elasticsearch/client/ElasticsearchClient.java
Outdated
Show resolved
Hide resolved
| private void createIndex(String indexName) | ||
| throws IOException | ||
| { | ||
| client.getLowLevelClient().performRequest("PUT", "/" + indexName, ImmutableMap.of()); |
There was a problem hiding this comment.
is it equiv to createIndex(indexName, '{}')?
There was a problem hiding this comment.
No, ElasticsearchClient expects at least one property to be present when processing mappings.
presto-elasticsearch/src/main/java/io/prestosql/elasticsearch/ElasticsearchMetadata.java
Outdated
Show resolved
Hide resolved
martint
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty indexes can cause exceptions when trying to query the corresponding table or the information schema (e.g. the
columnstable).