Pushdown domains with many ranges in Oracle connector #4918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
approved these changes
Aug 21, 2020
| @@ -128,7 +128,7 @@ protected TestTable createTableWithDefaultColumns() | |||
| @Override | |||
| public void testLargeIn() | |||
| { | |||
| int numberOfElements = 1000; | |||
| int numberOfElements = 5000; | |||
There was a problem hiding this comment.
yes, this was overridden only to change the number of elements..
There was a problem hiding this comment.
There is still this extra part in Oracle test which is not present in superclass:
String arrayValues = range(0, numberOfElements)
.mapToObj(i -> format("ARRAY[%s, %s, %s]", i, i + 1, i + 2))
.collect(joining(", "));
assertQuery("SELECT ARRAY[0, 0, 0] in (ARRAY[0, 0, 0], " + arrayValues + ")", "values true");
assertQuery("SELECT ARRAY[0, 0, 0] in (" + arrayValues + ")", "values false");
I can call out to super anyway though, even if we still want test with arrays.
| } | ||
| else { | ||
| // full pushdown | ||
| return new PredicatePushdownController.DomainPushdownResult(domain, Domain.all(domain.getType())); |
There was a problem hiding this comment.
You eliminate a filter here. Do we have a predicate pushdown test for Oracle, like we have for postgres?
eskabetxe
approved these changes
Aug 22, 2020
losipiuk
force-pushed
the
lo/oracle-simplify-domain
branch
from
c6f3a9a
to
ed4a726
Compare
|
ac |
losipiuk
force-pushed
the
lo/oracle-simplify-domain
branch
3 times, most recently
from
ab0a9a9
to
422bd3c
Compare
If domain has more that 1000 ranges it is simplified, before pushdown attempt. Without this query would fails with: ORA-01795: maximum number of expressions in a list is 1000
losipiuk
force-pushed
the
lo/oracle-simplify-domain
branch
from
422bd3c
to
4769784
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If domain has more that 1000 ranges it is simplified, before pushdown
attempt. Without this query would fails with:
ORA-01795: maximum number of expressions in a list is 1000