Add support for CREATE and DROP SCHEMA in BigQuery #7543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
reviewed
Apr 12, 2021
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryMetadata.java
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryMetadata.java
Outdated
Show resolved
Hide resolved
| assertUpdate("DROP SCHEMA " + schemaName); | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
Please add a test when you try to drop schema in case when case insensitive mapping is enabled.
Test a case when only single schema matches DROP request (it should be allowed).
And a case when there are multiple matching schemas. In that case DROP should raise an exception.
There was a problem hiding this comment.
perhaps instead of adding expicit tests here we could leverage io.trino.testing.BaseConnectorSmokeTest#testCreateSchema or io.trino.testing.BaseConnectorTest (AbstractTestDistributedQueries)#testCreateSchema
ebyhr
force-pushed
the
bigquery-create-drop-schema
branch
from
aac5620
to
e12eba4
Compare
losipiuk
approved these changes
Apr 19, 2021
ebyhr
force-pushed
the
bigquery-create-drop-schema
branch
from
e12eba4
to
993a711
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.