Allow assuming an AWS IAM Role in Elasticsearch connector #8714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lucasdlemos
commented
Jul 29, 2021
lucasdlemos
commented
- Add optional configuration to allow assuming an IAM Role in the Elasticsearch connector
- Update connector documentation to mention the new configs
martint
requested changes
Jul 29, 2021
...no-elasticsearch/src/main/java/io/trino/plugin/elasticsearch/client/ElasticsearchClient.java
Outdated
Show resolved
Hide resolved
|
Please squash the two commits, as they are part of the same logical change. |
lucasdlemos
force-pushed
the
elasticsearch-iam-role
branch
from
1fe14e1
to
ce66a3a
Compare
|
Thanks, @martint. I Applied the changes you asked. |
kokosing
reviewed
Jul 29, 2021
plugin/trino-elasticsearch/src/main/java/io/trino/plugin/elasticsearch/AwsSecurityConfig.java
Outdated
Show resolved
Hide resolved
Add an additional optional configuration to the Elasticsearch connector to assume an IAM role if provided.
lucasdlemos
force-pushed
the
elasticsearch-iam-role
branch
from
ce66a3a
to
0c17d4f
Compare
@kokosing I've manually tested it. As of now we don't have Trino product tests with AWS. |
martint
approved these changes
Jul 29, 2021
|
CI failure is unrelated: #6991 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.