New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Connection URI to MongoDB Connector #9819

Merged

ebyhr merged 1 commit into trinodb:master from Juacall:MongoDB-Update

Dec 2, 2021

Contributor

Juacall commented Oct 29, 2021 •

edited by ebyhr

Loading

Fixes #3460 Fixes #8591 Fixes #5810 Fixes #1573

cla-bot bot added the cla-signed label

ebyhr self-requested a review

October 29, 2021 23:50

ebyhr reviewed

View reviewed changes

Member

ebyhr left a comment

Please take a look at CI failure.
https://github.com/trinodb/trino/runs/4052292513

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoSession.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientConfig.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/MongoServer.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/MongoServer.java Outdated Show resolved Hide resolved

ebyhr reviewed

View reviewed changes

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientConfig.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoSession.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoSession.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoSplitManager.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/ObjectIdFunctions.java Outdated Show resolved Hide resolved

docs/src/main/sphinx/connector/mongodb.rst Outdated Show resolved Hide resolved

docs/src/main/sphinx/connector/mongodb.rst Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/BaseMongoDistributedQueries.java Show resolved Hide resolved

plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/MongoQueryRunner.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/MongoServer.java Outdated Show resolved Hide resolved

Juacall force-pushed the MongoDB-Update branch from 23b0eb1 to b630f35 Compare

November 2, 2021 02:43

Juacall requested a review from ebyhr

November 3, 2021 16:02

ebyhr reviewed

View reviewed changes

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientConfig.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientConfig.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoMetadata.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientConfig.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoSplitManager.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoSession.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/BaseMongoDistributedQueries.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/MongoQueryRunner.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/TestMongoClientConfig.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/TestMongoPlugin.java Outdated Show resolved Hide resolved

Juacall force-pushed the MongoDB-Update branch from ed6caf7 to b1c1ac1 Compare

November 9, 2021 05:35

Juacall requested a review from ebyhr

November 9, 2021 10:14

ebyhr mentioned this pull request

Add support for MongoDB cluster using TLS #6401

Closed

ebyhr reviewed

View reviewed changes

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientConfig.java Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoMetadata.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoMetadata.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoSession.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoSession.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoSession.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/MongoQueryRunner.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/MongoQueryRunner.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/BaseMongoDistributedQueries.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientConfig.java Outdated Show resolved Hide resolved

Juacall force-pushed the MongoDB-Update branch from 181affb to 3f00d15 Compare

November 10, 2021 16:53

Juacall requested a review from ebyhr

November 11, 2021 01:48

ebyhr reviewed

View reviewed changes

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientConfig.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientConfig.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientConfig.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientConfig.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientConfig.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/BaseMongoDistributedQueries.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/MongoServer.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientConfig.java Outdated Show resolved Hide resolved

Juacall force-pushed the MongoDB-Update branch from 7d0b6e8 to f2f4eeb Compare

November 18, 2021 16:37

ebyhr reviewed

View reviewed changes

docs/src/main/sphinx/connector/mongodb.rst Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientConfig.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientConfig.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/MongoQueryRunner.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientModule.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientConfig.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientModule.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/BaseMongoDistributedQueries.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoMetadata.java Outdated Show resolved Hide resolved

Juacall force-pushed the MongoDB-Update branch from 620c696 to 2648d38 Compare

November 22, 2021 06:49

ebyhr reviewed

View reviewed changes

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientConfig.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientConfig.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientConfig.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientModule.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoMetadata.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/BaseMongoDistributedQueries.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/pom.xml Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientModule.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientModule.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/BaseMongoDistributedQueries.java Outdated Show resolved Hide resolved

Juacall force-pushed the MongoDB-Update branch from 9449611 to 3580012 Compare

November 24, 2021 06:18

ebyhr reviewed

View reviewed changes

Member

ebyhr left a comment

Almost good to me.

docs/src/main/sphinx/connector/mongodb.rst Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientConfig.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/WriteConcernType.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/ObjectIdFunctions.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/MongoServer.java Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoMetadata.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientModule.java Outdated Show resolved Hide resolved

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientModule.java Outdated Show resolved Hide resolved

ebyhr reviewed

View reviewed changes

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoClientConfig.java Outdated Show resolved Hide resolved

Juacall force-pushed the MongoDB-Update branch from 32d6a13 to 8ba1ba3 Compare

November 24, 2021 07:23

Juacall requested a review from ebyhr

November 27, 2021 05:53

ebyhr approved these changes

View reviewed changes

docs/src/main/sphinx/connector/mongodb.rst Outdated Show resolved Hide resolved

docs/src/main/sphinx/connector/mongodb.rst Outdated Show resolved Hide resolved

Juacall requested a review from ebyhr

December 2, 2021 04:20

ebyhr approved these changes

View reviewed changes

Member

ebyhr left a comment

Please squash commits into one.

Juacall force-pushed the MongoDB-Update branch from 404ede3 to f2e09ee Compare

December 2, 2021 05:09

Juacall requested a review from ebyhr

December 2, 2021 05:09

ebyhr reviewed

View reviewed changes

plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/MongoServer.java Show resolved Hide resolved

Juacall force-pushed the MongoDB-Update branch from 87a0d17 to 3e6a045 Compare

December 2, 2021 05:53

Juacall requested a review from ebyhr

December 2, 2021 05:53

ebyhr requested changes

View reviewed changes

plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/ObjectIdFunctions.java Outdated Show resolved Hide resolved

Juacall force-pushed the MongoDB-Update branch from 3e6a045 to d3bbb1e Compare

December 2, 2021 08:05


          Add Support for Connection URI to MongoDB Connector

488fea6

Juacall force-pushed the MongoDB-Update branch from d3bbb1e to 488fea6 Compare

December 2, 2021 08:13

Juacall requested a review from ebyhr

December 2, 2021 08:13

ebyhr approved these changes

View reviewed changes

ebyhr merged commit 0ae5f2a into trinodb:master

Member

ebyhr commented Dec 2, 2021

Merged, thanks!

ebyhr mentioned this pull request

Release notes for 365 #9826

Closed

12 tasks

github-actions bot added this to the 365 milestone

ebyhr mentioned this pull request

Support MongoDB TLS configuration #6364

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment