-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Kafka docs with encoder info #4530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks nice. It matches the quality of decoder documentation. I am not entirely sure if the structure is what we want in the long-term, but IMO this is great for now.
@mosabua do you wan to take a look?
1cfcd80
to
780b187
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to explain how to use this more in detail and what you achieve by doing this. Specifically this enables INSERT query support (writing data) ..
780b187
to
670b377
Compare
c06cfe1
to
145c4f8
Compare
Adding WIP label since @charlesjmorgan is adding JSON info and then I will do another review... ping me when its ready for that Charles |
145c4f8
to
5ef82bb
Compare
added JSON encoder documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Great work.
5ef82bb
to
4924572
Compare
@electrum this is ready to be merged 🚀 |
4924572
to
a1f973c
Compare
@electrum thanks for all the feedback! |
Thanks! |
Congrats @charlesjmorgan ! |
add docs for Kafka inserts and raw, avro, json, and csv encoders