Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kafka docs with encoder info #4530

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

charlesjmorgan
Copy link
Member

@charlesjmorgan charlesjmorgan commented Jul 22, 2020

add docs for Kafka inserts and raw, avro, json, and csv encoders

Copy link
Member

@losipiuk losipiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks nice. It matches the quality of decoder documentation. I am not entirely sure if the structure is what we want in the long-term, but IMO this is great for now.

@mosabua do you wan to take a look?

presto-docs/src/main/sphinx/connector/kafka.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/connector/kafka.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/connector/kafka.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/connector/kafka.rst Outdated Show resolved Hide resolved
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to explain how to use this more in detail and what you achieve by doing this. Specifically this enables INSERT query support (writing data) ..

@charlesjmorgan charlesjmorgan changed the title Update kafka docs with encoder info Update Kafka docs with encoder info Jul 24, 2020
@mosabua mosabua added the WIP label Jul 31, 2020
@mosabua
Copy link
Member

mosabua commented Jul 31, 2020

Adding WIP label since @charlesjmorgan is adding JSON info and then I will do another review... ping me when its ready for that Charles

@charlesjmorgan
Copy link
Member Author

added JSON encoder documentation

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Great work.

@charlesjmorgan
Copy link
Member Author

@electrum this is ready to be merged 🚀

presto-docs/src/main/sphinx/connector/kafka.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/connector/kafka.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/connector/kafka.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/connector/kafka.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/connector/kafka.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/connector/kafka.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/connector/kafka.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/connector/kafka.rst Outdated Show resolved Hide resolved
presto-docs/src/main/sphinx/connector/kafka.rst Outdated Show resolved Hide resolved
@charlesjmorgan
Copy link
Member Author

@electrum thanks for all the feedback!

@electrum electrum merged commit 7b48dbb into trinodb:master Aug 7, 2020
@electrum
Copy link
Member

electrum commented Aug 7, 2020

Thanks!

@mosabua
Copy link
Member

mosabua commented Aug 7, 2020

Congrats @charlesjmorgan !

@charlesjmorgan charlesjmorgan deleted the kafka-inserts-docs branch June 7, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants