Support multiple LDAP user bind patterns #5874
Conversation
| String groupSearch = replaceUser(groupAuthorizationSearchPattern.get(), user); | ||
| if (!isGroupMember(searchBase, groupSearch, userDistinguishedName, credential.getPassword())) { | ||
| String message = format("User [%s] not a member of an authorized group", user); | ||
| log.debug(message); |
There was a problem hiding this comment.
There is no point in logging when you throw
There was a problem hiding this comment.
I agree, but all of the code in this class logs and throws, so I copied the style of the existing code.
There was a problem hiding this comment.
The authentication code is kind of an exception, since the access denied causes an auth failure without any stack trace or logging. We might want to move the logging to the authentication system itself, but that's a separate project from this refactoring.
There was a problem hiding this comment.
Talked to @electrum, we're going to leave this as is for now
...ssword-authenticators/src/main/java/io/prestosql/plugin/password/ldap/LdapAuthenticator.java
Show resolved
Hide resolved
...ssword-authenticators/src/main/java/io/prestosql/plugin/password/ldap/LdapAuthenticator.java
Show resolved
Hide resolved
...thenticators/src/main/java/io/prestosql/plugin/password/ldap/JdkLdapAuthenticatorClient.java
Outdated
Show resolved
Hide resolved
...rd-authenticators/src/test/java/io/prestosql/plugin/password/ldap/TestLdapAuthenticator.java
Show resolved
Hide resolved
|
@kokosing I added another commit with some abstractions to simplify this code, but I didn't change the logging as that is what the existing code did. |
...ssword-authenticators/src/main/java/io/prestosql/plugin/password/ldap/LdapAuthenticator.java
Outdated
Show resolved
Hide resolved
...ssword-authenticators/src/main/java/io/prestosql/plugin/password/ldap/LdapAuthenticator.java
Outdated
Show resolved
Hide resolved
...ssword-authenticators/src/main/java/io/prestosql/plugin/password/ldap/LdapAuthenticator.java
Outdated
Show resolved
Hide resolved
...-authenticators/src/main/java/io/prestosql/plugin/password/ldap/LdapAuthenticatorClient.java
Show resolved
Hide resolved
...-authenticators/src/main/java/io/prestosql/plugin/password/ldap/LdapAuthenticatorClient.java
Outdated
Show resolved
Hide resolved
...ssword-authenticators/src/main/java/io/prestosql/plugin/password/ldap/LdapAuthenticator.java
Show resolved
Hide resolved
No description provided.