Fix incorrect result for decimal division #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dain
approved these changes
Jun 11, 2019
Simplify the implementation based on Hacker's Delight 9-3
When the first divisor doesn't fit in the first "32-bit" digit of the dividend and the whole 64-bit dividend is too big to fit in an unsigned long, the value becomes negative and regular division breaks down.
martint
force-pushed
the
decimal-division
branch
from
3c5e599
to
7b1f56a
Compare
|
I updated the code to use the existing divideUnsigned, which is more efficient than Java's Long.divideUnsigned when one of the numbers is large (i.e., negative). |
dain
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the first divisor doesn't fit in the first "32-bit" digit of the
dividend and the whole 64-bit dividend is too big to fit in an unsigned
long, the value becomes negative and regular division breaks down.
Fixes #958