Introduce Hive AccessControlMetadata #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #971 |
electrum
approved these changes
Jun 30, 2019
| @Override | ||
| public void createRole(ConnectorSession session, String role, Optional<HivePrincipal> grantor) | ||
| { | ||
| // roles are case insensitive in Hive |
There was a problem hiding this comment.
This comment is confusing, because the code here seems to be case sensitive.
There was a problem hiding this comment.
Correct. It looks like a bug that existed before. Let me fix that in separate PR.
| @Override | ||
| public List<GrantInfo> listTablePrivileges(ConnectorSession session, List<SchemaTableName> tableNames) | ||
| { | ||
| Set<HivePrincipal> principals = listEnabledPrincipals(metastore, session.getIdentity()) |
There was a problem hiding this comment.
Both usages collect to a set. I'd change the method to return a set.
There was a problem hiding this comment.
This method listEnabledPrincipals is also used to verify if user has an access to a table. Populating whole set all the time may affect query semantic analysis time.
|
|
||
| import io.prestosql.plugin.hive.metastore.SemiTransactionalHiveMetastore; | ||
|
|
||
| public class StaticAccessControlMetadataFactory |
There was a problem hiding this comment.
Let's put this inside StaticAccessControlMetadataModule so that it's consistent with SqlStandardAccessControlMetadataFactory.
Thanks to this we can modify and access security access control metadata depending on which security model is used in Hive Connector.
kokosing
force-pushed
the
origin/master/128_access_control_metadata
branch
2 times, most recently
from
dc5cdd3
to
80368b5
Compare
This was referenced Jul 4, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.