Consistent header and footer for blog #53
Conversation
- externalized header and footer from default - added usage for blog related layouts - added youtube channel link to footer (and image) - added highlighting for blog link in nav Signed-off-by: Manfred Moser <mmoser@apache.org> Signed-off-by: Manfred Moser <manfred@simpligility.com>
|
preview image from local run of site |
|
|
||
| <header class="hero clearfix"> | ||
| <div class="width"> | ||
| <h1>Blog</h1> |
There was a problem hiding this comment.
The font for this doesn't match the font for the header in other pages.
There was a problem hiding this comment.
hm ... probably a side effect of the separate css for blog .. let me debug this some more. Might be a bigger cleanup needed. Fingers crossed I can just remove the usage of the blog css or override locally
There was a problem hiding this comment.
Ouch ... side effects galore.
There was a problem hiding this comment.
Found and pushed a fix. Reordering css imports ftw!
|
There's something about the website css that's causing the layout in at least one blog post to break. Take a look at: https://deploy-preview-53--prestosql.netlify.com/blog/2019/05/21/optimizing-the-casts-away.html#putting-it-all-together See how the formula numbers on the right no longer line up. |
- in https://prestosql.io/blog/2019/05/21/optimizing-the-casts-away.html - needed to remove extra spacing for li on left to allow formula to fit - in the long run we will make the blog same width as other pages Signed-off-by: Manfred Moser <mmoser@apache.org> Signed-off-by: Manfred Moser <manfred@simpligility.com>
|
@martint Pushed a fix for the alignment. In the long run I think we want to make the blog use the same style as the rest of the site .. maybe even the same for the docs. Atm I am just trying to fix the big issues= while I work towards understanding all the setup and such. |
|
Also made it so that the width of the blog matches the width of the other pages on the site now. Can we get this merged? |
|
Merged, thanks! |
Signed-off-by: Manfred Moser mmoser@apache.org
Signed-off-by: Manfred Moser manfred@simpligility.com