Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve incbin calculation errors in calcrom.pl #135

Merged
merged 1 commit into from
Jun 25, 2023
Merged

Resolve incbin calculation errors in calcrom.pl #135

merged 1 commit into from
Jun 25, 2023

Conversation

WhenGryphonsFly
Copy link
Contributor

This trims, sorts, and deduplicates the results of the incbin command; which resolves the overcounting that was previously displayed. I don't know why the command was finding duplicates; I only resolved the symptoms, not the cause.

Trimming (the awk command) is necessary; there are some lines that differ only in the number of spaces at the beginning of the line.

The runtime of calcrom did increase by about ~25%, so this may need an increase in the timeout if this takes substantially longer in the CI than on my computer.

I can be contacted at whengryphonsfly on Discord.

Old:

725060 total bytes of code
309176 bytes of code in src (42.6414%)
415884 bytes of code in asm (57.3586%)

224158 total symbols
8412 symbols documented (3.7527%)
300 symbols partially documented (0.1338%)
215446 symbols undocumented (96.1135%)

32059292 total bytes of data
62051 bytes of data in src (0.1936%)
31997241 bytes of data in data (99.8064%)

82851021 bytes of data in 525417 incbins (258.4306%)

real	0m15.133s
user	0m19.095s
sys	0m0.688s

New:

725060 total bytes of code
309176 bytes of code in src (42.6414%)
415884 bytes of code in asm (57.3586%)

224158 total symbols
8412 symbols documented (3.7527%)
300 symbols partially documented (0.1338%)
215446 symbols undocumented (96.1135%)

32059292 total bytes of data
62051 bytes of data in src (0.1936%)
31997241 bytes of data in data (99.8064%)

27617007 bytes of data in 175139 incbins (86.1435%)

real	0m19.436s
user	0m21.523s
sys	0m0.786s

@SethBarberee SethBarberee merged commit debc272 into pret:master Jun 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants