Resolve incbin calculation errors in calcrom.pl #135
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This trims, sorts, and deduplicates the results of the incbin command; which resolves the overcounting that was previously displayed. I don't know why the command was finding duplicates; I only resolved the symptoms, not the cause.
Trimming (the awk command) is necessary; there are some lines that differ only in the number of spaces at the beginning of the line.
The runtime of calcrom did increase by about ~25%, so this may need an increase in the timeout if this takes substantially longer in the CI than on my computer.
I can be contacted at whengryphonsfly on Discord.
Old:
New: