Skip to content

Commit

Permalink
Improve use of palette macro and use PAL_* constants (#1087)
Browse files Browse the repository at this point in the history 
* Improve use of palette macro and use PAL_* constants

* Use proper constant for battle stats (#1088)

* Add suggestions about function names and variables

* Add colors macro

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
  • Loading branch information
@vulcandth
vulcandth and vulcandth committed Nov 17, 2023
1 parent a2fbacf commit dc1c8d3
Show file tree
Hide file tree
Showing 12 changed files with 24 additions and 24 deletions.
4 changes: 2 additions & 2 deletions pokecrystal.map
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23100,8 +23100,8 @@ ROMX bank #50:
$4e35 = BGEffect_RapidCyclePals.okay_3_cgb
$4e43 = BGEffect_RapidCyclePals.okay_4_cgb
$4e49 = BGEffect_RapidCyclePals.four_cgb
$4e52 = BGEffects_LoadBGPal0_OBPal1
$4e7f = BGEffects_LoadBGPal1_OBPal0
$4e52 = BGEffects_LoadPlayerPals
$4e7f = BGEffects_LoadEnemyPals
$4eac = BattleBGEffect_GetFirstDMGPal
$4eb2 = BattleBGEffect_GetNextDMGPal
$4ec6 = BattleBGEffect_GetNextDMGPal.repeat
Expand Down
4 changes: 2 additions & 2 deletions pokecrystal.sym
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22813,8 +22813,8 @@
32:4e35 BGEffect_RapidCyclePals.okay_3_cgb
32:4e43 BGEffect_RapidCyclePals.okay_4_cgb
32:4e49 BGEffect_RapidCyclePals.four_cgb
32:4e52 BGEffects_LoadBGPal0_OBPal1
32:4e7f BGEffects_LoadBGPal1_OBPal0
32:4e52 BGEffects_LoadPlayerPals
32:4e7f BGEffects_LoadEnemyPals
32:4eac BattleBGEffect_GetFirstDMGPal
32:4eb2 BattleBGEffect_GetNextDMGPal
32:4ec6 BattleBGEffect_GetNextDMGPal.repeat
Expand Down
4 changes: 2 additions & 2 deletions pokecrystal11.map
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23100,8 +23100,8 @@ ROMX bank #50:
$4e35 = BGEffect_RapidCyclePals.okay_3_cgb
$4e43 = BGEffect_RapidCyclePals.okay_4_cgb
$4e49 = BGEffect_RapidCyclePals.four_cgb
$4e52 = BGEffects_LoadBGPal0_OBPal1
$4e7f = BGEffects_LoadBGPal1_OBPal0
$4e52 = BGEffects_LoadPlayerPals
$4e7f = BGEffects_LoadEnemyPals
$4eac = BattleBGEffect_GetFirstDMGPal
$4eb2 = BattleBGEffect_GetNextDMGPal
$4ec6 = BattleBGEffect_GetNextDMGPal.repeat
Expand Down
4 changes: 2 additions & 2 deletions pokecrystal11.sym
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22813,8 +22813,8 @@
32:4e35 BGEffect_RapidCyclePals.okay_3_cgb
32:4e43 BGEffect_RapidCyclePals.okay_4_cgb
32:4e49 BGEffect_RapidCyclePals.four_cgb
32:4e52 BGEffects_LoadBGPal0_OBPal1
32:4e7f BGEffects_LoadBGPal1_OBPal0
32:4e52 BGEffects_LoadPlayerPals
32:4e7f BGEffects_LoadEnemyPals
32:4eac BattleBGEffect_GetFirstDMGPal
32:4eb2 BattleBGEffect_GetNextDMGPal
32:4ec6 BattleBGEffect_GetNextDMGPal.repeat
Expand Down
4 changes: 2 additions & 2 deletions pokecrystal11_debug.map
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23112,8 +23112,8 @@ ROMX bank #50:
$4e35 = BGEffect_RapidCyclePals.okay_3_cgb
$4e43 = BGEffect_RapidCyclePals.okay_4_cgb
$4e49 = BGEffect_RapidCyclePals.four_cgb
$4e52 = BGEffects_LoadBGPal0_OBPal1
$4e7f = BGEffects_LoadBGPal1_OBPal0
$4e52 = BGEffects_LoadPlayerPals
$4e7f = BGEffects_LoadEnemyPals
$4eac = BattleBGEffect_GetFirstDMGPal
$4eb2 = BattleBGEffect_GetNextDMGPal
$4ec6 = BattleBGEffect_GetNextDMGPal.repeat
Expand Down
4 changes: 2 additions & 2 deletions pokecrystal11_debug.sym
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22825,8 +22825,8 @@
32:4e35 BGEffect_RapidCyclePals.okay_3_cgb
32:4e43 BGEffect_RapidCyclePals.okay_4_cgb
32:4e49 BGEffect_RapidCyclePals.four_cgb
32:4e52 BGEffects_LoadBGPal0_OBPal1
32:4e7f BGEffects_LoadBGPal1_OBPal0
32:4e52 BGEffects_LoadPlayerPals
32:4e7f BGEffects_LoadEnemyPals
32:4eac BattleBGEffect_GetFirstDMGPal
32:4eb2 BattleBGEffect_GetNextDMGPal
32:4ec6 BattleBGEffect_GetNextDMGPal.repeat
Expand Down
4 changes: 2 additions & 2 deletions pokecrystal11_vc.map
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23152,8 +23152,8 @@ ROMX bank #50:
$4e35 = BGEffect_RapidCyclePals.okay_3_cgb
$4e43 = BGEffect_RapidCyclePals.okay_4_cgb
$4e49 = BGEffect_RapidCyclePals.four_cgb
$4e52 = BGEffects_LoadBGPal0_OBPal1
$4e7f = BGEffects_LoadBGPal1_OBPal0
$4e52 = BGEffects_LoadPlayerPals
$4e7f = BGEffects_LoadEnemyPals
$4eac = BattleBGEffect_GetFirstDMGPal
$4eb2 = BattleBGEffect_GetNextDMGPal
$4ec6 = BattleBGEffect_GetNextDMGPal.repeat
Expand Down
4 changes: 2 additions & 2 deletions pokecrystal11_vc.sym
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22865,8 +22865,8 @@
32:4e35 BGEffect_RapidCyclePals.okay_3_cgb
32:4e43 BGEffect_RapidCyclePals.okay_4_cgb
32:4e49 BGEffect_RapidCyclePals.four_cgb
32:4e52 BGEffects_LoadBGPal0_OBPal1
32:4e7f BGEffects_LoadBGPal1_OBPal0
32:4e52 BGEffects_LoadPlayerPals
32:4e7f BGEffects_LoadEnemyPals
32:4eac BattleBGEffect_GetFirstDMGPal
32:4eb2 BattleBGEffect_GetNextDMGPal
32:4ec6 BattleBGEffect_GetNextDMGPal.repeat
Expand Down
4 changes: 2 additions & 2 deletions pokecrystal_au.map
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23100,8 +23100,8 @@ ROMX bank #50:
$4e35 = BGEffect_RapidCyclePals.okay_3_cgb
$4e43 = BGEffect_RapidCyclePals.okay_4_cgb
$4e49 = BGEffect_RapidCyclePals.four_cgb
$4e52 = BGEffects_LoadBGPal0_OBPal1
$4e7f = BGEffects_LoadBGPal1_OBPal0
$4e52 = BGEffects_LoadPlayerPals
$4e7f = BGEffects_LoadEnemyPals
$4eac = BattleBGEffect_GetFirstDMGPal
$4eb2 = BattleBGEffect_GetNextDMGPal
$4ec6 = BattleBGEffect_GetNextDMGPal.repeat
Expand Down
4 changes: 2 additions & 2 deletions pokecrystal_au.sym
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22813,8 +22813,8 @@
32:4e35 BGEffect_RapidCyclePals.okay_3_cgb
32:4e43 BGEffect_RapidCyclePals.okay_4_cgb
32:4e49 BGEffect_RapidCyclePals.four_cgb
32:4e52 BGEffects_LoadBGPal0_OBPal1
32:4e7f BGEffects_LoadBGPal1_OBPal0
32:4e52 BGEffects_LoadPlayerPals
32:4e7f BGEffects_LoadEnemyPals
32:4eac BattleBGEffect_GetFirstDMGPal
32:4eb2 BattleBGEffect_GetNextDMGPal
32:4ec6 BattleBGEffect_GetNextDMGPal.repeat
Expand Down
4 changes: 2 additions & 2 deletions pokecrystal_debug.map
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23112,8 +23112,8 @@ ROMX bank #50:
$4e35 = BGEffect_RapidCyclePals.okay_3_cgb
$4e43 = BGEffect_RapidCyclePals.okay_4_cgb
$4e49 = BGEffect_RapidCyclePals.four_cgb
$4e52 = BGEffects_LoadBGPal0_OBPal1
$4e7f = BGEffects_LoadBGPal1_OBPal0
$4e52 = BGEffects_LoadPlayerPals
$4e7f = BGEffects_LoadEnemyPals
$4eac = BattleBGEffect_GetFirstDMGPal
$4eb2 = BattleBGEffect_GetNextDMGPal
$4ec6 = BattleBGEffect_GetNextDMGPal.repeat
Expand Down
4 changes: 2 additions & 2 deletions pokecrystal_debug.sym
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22825,8 +22825,8 @@
32:4e35 BGEffect_RapidCyclePals.okay_3_cgb
32:4e43 BGEffect_RapidCyclePals.okay_4_cgb
32:4e49 BGEffect_RapidCyclePals.four_cgb
32:4e52 BGEffects_LoadBGPal0_OBPal1
32:4e7f BGEffects_LoadBGPal1_OBPal0
32:4e52 BGEffects_LoadPlayerPals
32:4e7f BGEffects_LoadEnemyPals
32:4eac BattleBGEffect_GetFirstDMGPal
32:4eb2 BattleBGEffect_GetNextDMGPal
32:4ec6 BattleBGEffect_GetNextDMGPal.repeat
Expand Down

0 comments on commit dc1c8d3

Please sign in to comment.