Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that there aren't too many OAM constants #1062

Closed
Rangi42 opened this issue Jul 27, 2023 · 0 comments
Closed

Verify that there aren't too many OAM constants #1062

Rangi42 opened this issue Jul 27, 2023 · 0 comments

Comments

@Rangi42
Copy link
Member

Rangi42 commented Jul 27, 2023

The oamframe macro declares an OAM ID (i.e. a SPRITE_ANIM_OAM_* or BATTLEANIMOAMSET_* constant (names to change pending #1055)). The last few IDs are reserved for non-frame commands ($FC oamdelete, $FD oamwait, $FE oamrestart, $FF oamend). The oam* macros should declare a constant for the last valid OAM frame ID, and assert that the numbers of sprite and battle OAM constants are not exceeding it.

Idain pushed a commit to Idain/pokecrystal that referenced this issue Sep 11, 2023
Idain pushed a commit to Idain/pokecrystal that referenced this issue Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant