Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bag Item Sprite Flickering fix in bugs_and_glitches.md does not work #1514

Closed
LOuroboros opened this issue Oct 12, 2021 · 1 comment · Fixed by #1688
Closed

Bag Item Sprite Flickering fix in bugs_and_glitches.md does not work #1514

LOuroboros opened this issue Oct 12, 2021 · 1 comment · Fixed by #1688

Comments

@LOuroboros
Copy link
Contributor

Since this piece of documentation is a part of the main repository, I figured I should open an issue ticket for it.

The fix, on top of being slightly out of date as the spriteId variable of the BagMenu struct was renamed to spritesId, does not work like it should even on a clean copy of Pokeemerald without any other modifications.

%pn_1327
@GriffinRichards
Copy link
Member

It was renamed spriteIds. GitHub has no way to merge issues so I'll close this one and link to it in the pre-existing issue.

@GriffinRichards GriffinRichards mentioned this issue Oct 12, 2021
Open
@rawr51919 rawr51919 mentioned this issue Jun 10, 2022
Closed
@rawr51919 rawr51919 mentioned this issue Jun 17, 2022
Merged
antoinejen pushed a commit to antoinejen/pokeemerald that referenced this issue Jul 18, 2022
@rawr51919
Add bugfix from bugs_and_glitches.md to BUGFIX
4e0e908 
Item flicker fix now in `BUGFIX`
Supersedes and resolves pret#1680
Fixes pret#1215
Fixes pret#1514
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add bugfix from bugs_and_glitches.md to BUGFIX
Fix item menu flicker fix documentation
2 participants
@LOuroboros @GriffinRichards