Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solved a bunch of -Wall errors on modern #1926

Merged
merged 5 commits into from
Oct 1, 2023
Merged

Solved a bunch of -Wall errors on modern #1926

merged 5 commits into from
Oct 1, 2023

Conversation

AsparagusEduardo
Copy link
Contributor

Description

Most of these were picked from rh-hideout#3267.

Discord contact info

AsparagusEduardo

GriffinRichards
GriffinRichards reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@GriffinRichards GriffinRichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to play devil's advocate, do we definitely want to silence unused warnings upstream? I'd think if someone enables -Wunused they might reasonably want to know about these from the compiler, as opposed to searching the repo.

src/fieldmap.c Outdated Show resolved Hide resolved
src/librfu_rfu.c Show resolved Hide resolved
src/m4a_tables.c Outdated Show resolved Hide resolved
src/battle_anim_effects_1.c Outdated Show resolved Hide resolved
@AsparagusEduardo
Copy link
Contributor Author

Just to play devil's advocate, do we definitely want to silence unused warnings upstream? I'd think if someone enables -Wunused they might reasonably want to know about these from the compiler, as opposed to searching the repo.

I was thinking that having them in the repo would be useful for users that want to do cleanup, by searching all instances of UNUSED directly instead of searching through the console log with -Wunused (which would get cutoff) or trying to compile 20+ times using -Werror=unused until it succedes.

@AsparagusEduardo
Copy link
Contributor Author

Changes applied.

@AsparagusEduardo
Copy link
Contributor Author

Fixed issue.

GriffinRichards
GriffinRichards reviewed Sep 26, 2023
View reviewed changes
src/librfu_rfu.c Outdated Show resolved Hide resolved
@AsparagusEduardo
Copy link
Contributor Author

Done.

@GriffinRichards GriffinRichards merged commit 654b638 into pret:master Oct 1, 2023
1 check passed
github-actions bot pushed a commit that referenced this pull request Oct 1, 2023
@GriffinRichards
Merge pull request #1926 from AsparagusEduardo/pret/pr2/EggWall
afabe89
github-actions bot pushed a commit to That-Human-Being/pokeemerald that referenced this pull request Oct 3, 2023
@That-Human-Being
Merge pull request pret#1926 from AsparagusEduardo/pret/pr2/EggWall
c0c2bf5
github-actions bot pushed a commit to GriffinRichards/pokeemerald that referenced this pull request Oct 4, 2023
@GriffinRichards
Merge pull request pret#1926 from AsparagusEduardo/pret/pr2/EggWall
ebe5fef
@AsparagusEduardo AsparagusEduardo deleted the pret/pr2/EggWall branch October 12, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GriffinRichards GriffinRichards GriffinRichards left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AsparagusEduardo @GriffinRichards