Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify various "????"s #116

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Identify various "????"s #116

merged 1 commit into from
Jun 12, 2024

Conversation

Rangi42
Copy link
Member

@Rangi42 Rangi42 commented May 24, 2024

Some of these were already identified, e.g. the audio ???s, and just had outdated comments.

The shell fragment angles are the same as the Game Freak logo sparkle angles.

@Rangi42 Rangi42 requested review from mid-kid and vulcandth May 24, 2024 18:53
@vulcandth
Copy link
Collaborator

Note: some of this would need to be ported to pokecrystal after merge.

audio/engine.asm Outdated Show resolved Hide resolved
@Rangi42 Rangi42 merged commit 98d7282 into pret:master Jun 12, 2024
1 check passed
@Rangi42 Rangi42 deleted the misc branch June 12, 2024 00:54
github-actions bot pushed a commit that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants