Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decompile overlay_12_0226BEC4, make HeapID into a proper enum #148

Merged
merged 13 commits into from
Jun 6, 2023
Merged

Decompile overlay_12_0226BEC4, make HeapID into a proper enum #148

merged 13 commits into from
Jun 6, 2023

Commits on Jun 3, 2023

  1. Make HeapID an enum 

    Also made some _ctor and _new -> _New
    @adrienntindall
    adrienntindall committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    8660536 View commit details
    Browse the repository at this point in the history

  2. Decompile overlay_12_0226BEC4

    @adrienntindall
    adrienntindall committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    02c7656 View commit details
    Browse the repository at this point in the history

  3. Removed accidently commited files

    @adrienntindall
    adrienntindall committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    952271e View commit details
    Browse the repository at this point in the history

  4. overlay_12_0226BBC4 -> battle_finger 

    This refers to the finger icon in the catching tutorial, I think
Also got *some* documentation for UnkStruct_0200D748 done in the process
    @adrienntindall
    adrienntindall committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    60fdb37 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2023

  1. Merge branch 'master' into master

    @adrienntindall
    adrienntindall committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    6e1c87f View commit details
    Browse the repository at this point in the history

  2. Fix warnings caused by merge

    @adrienntindall
    adrienntindall committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    7818a8a View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. Battle cursor 1, fix requested changes

    @adrienntindall
    adrienntindall committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    9849bf0 View commit details
    Browse the repository at this point in the history

  2. decompile overlay_12_0226B8FC -> battle_cursor.c

    @adrienntindall
    adrienntindall committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    9a3760b View commit details
    Browse the repository at this point in the history

  3. Some battle documentation 

    Old (left) versus new (right)
ov12_02248660 BattleContext_New
ov12_02250F44 BattleContext_Init
ov12_022486B0 BattleMain
ov12_0223BD14 BattleSystem_GetWinLoseFlags
ov12_0226CA90 sPlayerBattleCommands
ov12_022486FC BattleContext_Delete
ov12_0224BCC4 BattleSystem_CheckMoveHit
ov12_0224C018 BattleSystem_CheckMoveEffect
ov12_02248714 BattleSystem_CheckMoveHitEffect
ov12_0224873C BattleControllerPlayer_GetBattleMon
ov12_0224E4FC BattleSystem_GetBattleMon
    @adrienntindall
    adrienntindall committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    18b3c56 View commit details
    Browse the repository at this point in the history

  4. Some more documentation 

    ov12_02250370 BattleSystem_SetExperienceEarnFlags
ov12_02250360 BattleSystem_ClearExperienceEarnFlags
ov12_02255844 BattleSystem_GetHeldItemDamageBoost
ov12_0226340C BattleController_SetMoveEffect
    @adrienntindall
    adrienntindall committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    10ee7dc View commit details
    Browse the repository at this point in the history

  5. Added second set of requested changes 

    aside from int -> s32 stuff since I don't like that very much
    @adrienntindall
    adrienntindall committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    c5e7412 View commit details
    Browse the repository at this point in the history

  6. int -> s32

    @adrienntindall
    adrienntindall committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    eda37c4 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. Revert "int -> s32" 

    This reverts commit eda37c4.
    @adrienntindall
    adrienntindall committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    7655a2d View commit details
    Browse the repository at this point in the history