Pokepic #316
Open
Pokepic #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
adrienntindall
requested changes
Jul 10, 2024
| @@ -481,7 +482,7 @@ typedef struct OpponentData { | |||
| u32 unk0[6]; | |||
| u32 unk18; | |||
| u32 *unk1C; | |||
| u32 *unk20; | |||
| Pokepic *unk20; | |||
There was a problem hiding this comment.
unk20 -> pokepic? low priority but nice to have done now
| void sub_02070130(struct SomeDrawPokemonStruct *a0, BoxPokemon *boxMon, u8 whichFacing); | ||
| void GetBoxmonSpriteCharAndPlttNarcIds(struct SomeDrawPokemonStruct *spC, BoxPokemon *boxMon, u8 whichFacing, BOOL sp14); | ||
| void GetMonSpriteCharAndPlttNarcIdsEx(struct SomeDrawPokemonStruct * spC, u16 species, u8 gender, u8 whichFacing, u8 shiny, u8 form, u32 personality); | ||
| void GetPokemonSpriteCharAndPlttNarcIds(PokepicTemplate *a0, Pokemon *mon, u8 whichFacing); |
There was a problem hiding this comment.
name all instances of PokepicTemplate params
| u8 sub_0207083C(BoxPokemon *boxMon, u8 whichFacing); | ||
| u8 sub_02070848(BoxPokemon *boxMon, u8 whichFacing); | ||
| u8 sub_02070854(BoxPokemon *boxMon, u8 whichFacing, BOOL a2); | ||
| u8 sub_020708D8(u16 species, u8 gender, u8 whichFacing, u8 form, u32 pid); | ||
| u8 sub_02070A64(u16 species, u8 gender, u8 whichFacing, u8 form, u32 pid); | ||
| u8 GetMonPicHeightBySpeciesGenderForme(u16 species, u8 gender, u8 whichFacing, u8 form, u32 pid); |
| u8 sub_020708D8(u16 species, u8 gender, u8 whichFacing, u8 form, u32 pid); | ||
| u8 sub_02070A64(u16 species, u8 gender, u8 whichFacing, u8 form, u32 pid); | ||
| u8 GetMonPicHeightBySpeciesGenderForme(u16 species, u8 gender, u8 whichFacing, u8 form, u32 pid); | ||
| u8 GetMonPicHeightBySpeciesGenderForme_PBR(u16 species, u8 gender, u8 whichFacing, u8 form, u32 pid); |
| void MTX_RotZ44_(register MtxFx44 * pDst, register fx32 sinVal, register fx32 cosVal); | ||
|
|
||
| static inline void MTX_Identity44 (MtxFx44 * pDst) { | ||
| MTX_Identity44_(pDst); |
There was a problem hiding this comment.
tabs -> spaces in this file
| Pokepic_MaybeAddSpindaSpots(&pokepicManager->pics[i], pRawCharData); | ||
|
|
||
| // This loop is crazy. Admittedly, I cheated and used retsam to guide this. | ||
| // Please don't tell reddo, she'll have my balls chopped off too. |
|
|
||
| typedef struct RegisterHofMon { | ||
| Pokemon *mon; | ||
| u8 tsure_param[4]; |
| data->spriteRenderer = SpriteRenderer_Create(HEAP_ID_REGISTER_HALL_OF_FAME); | ||
| data->spriteGfxHandler = SpriteRenderer_CreateGfxHandler(data->spriteRenderer); | ||
|
|
||
| { |
There was a problem hiding this comment.
scope brackes neded?
| } | ||
|
|
||
| static void RegisterHallOfFame_IndivMons_InitBgLayers(RegisterHallOfFameData *data) { | ||
| { |
| } | ||
|
|
||
| static void RegisterHallOfFame_WholePartyScene_InitBGs(RegisterHallOfFameData *data) { | ||
| { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #313