Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename EV_* constants to EVOLVE_* like pokecrystal #407

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

SatoMew
Copy link
Contributor

@SatoMew SatoMew commented Feb 11, 2023

I changed the constants to match pokegold and pokecrystal, and updated the remaining instances of the level-based evolution type.

@dannye
Copy link
Member

dannye commented Feb 11, 2023

The 1's that you replaced do not represent EV_LEVEL, they are the minimum level requirement for the EV_ITEM evolution that they are a part of.
https://github.com/pret/pokered/blob/master/engine/pokemon/evos_moves.asm#L102

@SatoMew
Copy link
Contributor Author

SatoMew commented Feb 12, 2023

oh, my apologies, I misunderstood what they represented.

@Rangi42
Copy link
Member

Rangi42 commented Feb 12, 2023

Thanks! This is a good start toward syncing gen 1 and 2 evos/attacks data, but should we leave this PR open to do more? For example, decide on one name (evos_attacks.asm or evos_moves.asm?), and consistent comments (; Evolutions and ; Learnset headers, or ; no more evolutions and ; no more level-up moves trailers?). Ideally a diff of the pokered and pokecrystal files would show the actual changes in game data, not asm formatting differences. If we decide pokered has the better choice sometimes, the gen 2 repos will need updating too.

@SatoMew
Copy link
Contributor Author

SatoMew commented Feb 12, 2023

Thanks! This is a good start toward syncing gen 1 and 2 evos/attacks data, but should we leave this PR open to do more?

I'm OK with that! 🙂

@Rangi42 Rangi42 marked this pull request as draft February 12, 2023 01:59
@SatoMew SatoMew closed this Feb 26, 2023
@SatoMew SatoMew deleted the evolve_symbols branch February 26, 2023 18:10
@SatoMew SatoMew restored the evolve_symbols branch February 26, 2023 18:17
@SatoMew SatoMew reopened this Feb 26, 2023
@Rangi42 Rangi42 marked this pull request as ready for review November 22, 2023 00:53
@Rangi42 Rangi42 changed the title Clean up evolution type symbols Rename EV_* constants to EVOLVE_* like pokecrystal Nov 22, 2023
@Rangi42
Copy link
Member

Rangi42 commented Nov 22, 2023

This is not being maintained, so merging as-is, just for the small pokecrystal sync.

@Rangi42 Rangi42 merged commit a681f71 into pret:master Nov 22, 2023
@SatoMew SatoMew deleted the evolve_symbols branch November 22, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants