New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable continuous integration #94
Conversation
What's |
It would detect edge cases where running Consider my patch in #92: at the moment, the only way to verify that it doesn’t mess anything up is by merging it locally, running |
Can someone review this please? |
I'm not speaking for everybody, but I don't think this is in our interest. Our makefile already verifies the output rom. |
Considering how low-lift adding CI to this project would be, I don't understand how anyone could argue against it. |
ACK, this looks reasonable to me. I like the idea of introducing continuous integration to the project and its users, who may be unfamiliar with the benefits of regular testing and builds. Let's do this. |
f869601
to
e3fcbcb
Compare
Is anybody still opposed to this? I've updated (Sanqui@d7bd7f4) the Travis script and I'm ready to set it up. |
Improved and accepted in #148, thank you! |
With this change, every commit pushed to master and every pull request received triggers a build. If anything breaks, e.g. if the MD5 hashes for generated ROMs are incorrect, it automatically reports an error straight in the GitHub pull request UI.
Example build log: https://travis-ci.org/PoCs/pokered/builds/151586998
For this to work, you’d have to enable Travis for this repository: https://docs.travis-ci.com/user/getting-started/#To-get-started-with-Travis-CI%3A