Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sound key split tables #639

Closed
huderlem opened this issue Jun 24, 2018 · 0 comments
Closed

Fix sound key split tables #639

huderlem opened this issue Jun 24, 2018 · 0 comments

Comments

@huderlem
Copy link
Member

Due to the way mks4agb (Nintendo's tool) works, key split table labels can (and do) appear before the actual start of the key split table data. If you look at the first keysplit table KeySplitTable_8455224, you'll notice there is some non-keysplit data that occurs before the real keysplit table begins. This is because the key split tables don't map instruments for the entire instrument range (0-127)--they only map subsets, and the upper and lower ranges aren't necessarily 0 or 127.

For example if a key split table maps an instrument range of 10-20, then the key split table label will occur 10 bytes before the actual key split data. Therefore, the instruments naturally map to the key split table without any extra offset calculation.

As a result, pokeruby's key split tables currently bleed into each other, and their is voice data bleeding into the first one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant