Skip to content

Commit

Permalink
Remove old TODO items
Browse files Browse the repository at this point in the history
  • Loading branch information
rixx committed Feb 16, 2024
1 parent e33919c commit 3dedb24
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 15 deletions.
1 change: 0 additions & 1 deletion src/pretalx/common/forms/fields.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@ class ExtensionFileField(ExtensionFileInput, SizeFileInput, FileField):


class ImageField(ExtensionFileInput, SizeFileInput, FileField):
# TODO: add better image field widget
widget = ImageInput

def __init__(self, *args, **kwargs):
Expand Down
3 changes: 0 additions & 3 deletions src/pretalx/common/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,6 @@ def is_form_bound(request, form_name, form_param="form"):


def get_static(request, path, content_type): # pragma: no cover
"""TODO: move to staticfiles usage as per https://gist.github.com/SmileyChris/8d472f2a67526e36f39f3c33520182bc
This would avoid potential directory traversal by … a malicious urlconfig, so not a huge attack vector.
"""
path = settings.BASE_DIR / "pretalx/static" / path
if not path.exists():
raise Http404()
Expand Down
6 changes: 2 additions & 4 deletions src/pretalx/mail/context.py
Original file line number Diff line number Diff line change
Expand Up @@ -255,10 +255,8 @@ def base_placeholders(sender, **kwargs):
_("The addressed user's email address"),
),
*placeholder_aliases(
[
"speaker_schedule_new",
"notifications",
], # TODO: remove alias in 2026, maybe
# TODO: remove alias in 2026, maybe
["speaker_schedule_new", "notifications"],
["user", "event"],
lambda user, event: render_notifications(
get_current_notifications(user, event),
Expand Down
2 changes: 1 addition & 1 deletion src/pretalx/orga/forms/event.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ class EventForm(ReadOnlyFlag, I18nHelpText, JsonSubfieldMixin, I18nModelForm):
required=False,
)
schedule = forms.ChoiceField(
label=_("Schedule display format"), # TODO show small preview / icons
label=_("Schedule display format"),
choices=(
("grid", _("Grid")),
("list", _("List")),
Expand Down
6 changes: 2 additions & 4 deletions src/pretalx/orga/views/cfp.py
Original file line number Diff line number Diff line change
Expand Up @@ -512,9 +512,7 @@ def post(self, request, *args, **kwargs):
orga=True,
)
messages.success(request, _("The Session Type has been deleted."))
except (
ProtectedError
): # TODO: show which/how many submissions are concerned
except ProtectedError:
messages.error(
request,
_(
Expand Down Expand Up @@ -580,7 +578,7 @@ def post(self, request, *args, **kwargs):
"pretalx.track.delete", person=self.request.user, orga=True
)
messages.success(request, _("The track has been deleted."))
except ProtectedError: # TODO: show which/how many submissions are concerned
except ProtectedError:
messages.error(
request,
_("This track is in use in a proposal and cannot be deleted."),
Expand Down
2 changes: 1 addition & 1 deletion src/pretalx/orga/views/schedule.py
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@ def dispatch(self, request, event, pk):
messages.success(
self.request, _("Room deleted. Hopefully nobody was still in there …")
)
except ProtectedError: # TODO: show which/how many talks are concerned
except ProtectedError:
messages.error(
request,
_(
Expand Down
1 change: 0 additions & 1 deletion src/pretalx/schedule/exporters.py
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,6 @@ def get_data(self, **kwargs):
"timeslot_duration": "00:05",
"time_zone_name": self.event.timezone,
"colors": {"primary": self.event.primary_color or "#3aa57c"},
# "url": self.event.urls.base.full(), # TODO this should be the URL of the conference website itself, but we do not have a field for this value yet
"rooms": [
{
"name": str(room.name),
Expand Down

0 comments on commit 3dedb24

Please sign in to comment.