[orga] Let organisers decide if review scores are mandatory

Same goes for texts. Closes #340

CHANGELOG.rst

@@ -16,12 +16,11 @@ Breaking Changes
 
 Features
 ~~~~~~~~
-
+- Organisers can now decide if reviewers should be required to submit a score or a text with their review. (#340)
 
 Fixed bugs
 ~~~~~~~~~~~
 - In the dashboard, an incorrect link was given to add new reviewers. (#344)
 - The "save" button was missing on the mail settings page. (#341)
 
-
 .. _releases: https://github.com/pretalx/pretalx/releases

src/pretalx/common/models/settings.py

@@ -19,6 +19,8 @@ class GlobalSettings(GlobalSettingsBase):
 settings_hierarkey.add_default('allow_override_votes', 'False', bool)
 settings_hierarkey.add_default('review_min_score', 0, int)
 settings_hierarkey.add_default('review_max_score', 1, int)
+settings_hierarkey.add_default('review_score_mandatory', 'False', bool)
+settings_hierarkey.add_default('review_text_mandatory', 'False', bool)
 
 settings_hierarkey.add_default('mail_from', 'noreply@example.org', str)
 settings_hierarkey.add_default('smtp_use_custom', 'False', bool)

src/pretalx/orga/forms/cfp.py

@@ -13,6 +13,14 @@
 class CfPSettingsForm(ReadOnlyFlag, I18nFormMixin, HierarkeyForm):
     cfp_show_deadline = forms.BooleanField(label=_('Display deadline publicly'),
                                            required=False)
+    review_score_mandatory = forms.BooleanField(
+        label=_('Require reviewers to submit a score'),
+        required=False,
+    )
+    review_text_mandatory = forms.BooleanField(
+        label=_('Require reviewers to submit a text'),
+        required=False,
+    )
     mail_on_new_submission = forms.BooleanField(
         label=_('Send mail on new submission'),
         help_text=_('If this setting is checked, you will receive an email to the orga address for every received submission.'),

src/pretalx/orga/forms/review.py

@@ -21,7 +21,7 @@ def __init__(self, event, user, *args, instance=None, **kwargs):
                 instance.score = self.min_value - 1
 
         super().__init__(*args, instance=instance, **kwargs)
-        choices = [(None, _('No score'))]
+        choices = [(None, _('No score'))] if not event.settings.review_score_mandatory else []
         if self.may_override:
             choices.append((self.min_value - 1, _('Negative override (Veto)')))
         for counter in range(abs(self.max_value - self.min_value) + 1):
@@ -35,9 +35,14 @@ def __init__(self, event, user, *args, instance=None, **kwargs):
         if self.may_override:
             choices.append((self.max_value + 1, _('Positive override')))
 
-        self.fields['score'] = forms.ChoiceField(choices=choices, required=False, disabled=kwargs.get('read_only', False))
+        self.fields['score'] = forms.ChoiceField(
+            choices=choices,
+            required=event.settings.review_score_mandatory,
+            disabled=kwargs.get('read_only', False),
+        )
         self.fields['text'].widget.attrs['rows'] = 2
         self.fields['text'].widget.attrs['placeholder'] = phrases.orga.example_review
+        self.fields['text'].required = event.settings.review_text_mandatory
 
     def clean_score(self):
         score = self.cleaned_data.get('score')

src/pretalx/orga/templates/orga/cfp/text.html

@@ -27,6 +27,8 @@
 
             <legend>{% trans "Review settings" %}</legend>
             {% bootstrap_field sform.allow_override_votes layout='event' %}
+            {% bootstrap_field sform.review_score_mandatory layout='event' %}
+            {% bootstrap_field sform.review_text_mandatory layout='event' %}
             {% bootstrap_field sform.review_min_score layout='event' %}
             {% bootstrap_field sform.review_max_score layout='event' %}
             {% for field in sform %}