Add fallback value for room guid (#1530)

src/pretalx/agenda/templates/agenda/schedule.xml

@@ -19,7 +19,7 @@
         {% endfor %}
     </conference>
     {% for day in data %}<day index='{{ day.index }}' date='{{ day.start.date|date:"c" }}' start='{{ day.start|date:"c" }}' end='{{ day.end|date:"c" }}'>
-        {% for room in day.rooms %}<room name='{{ room.name|xmlescape }}'{% if room.guid %} guid='{{ room.guid }}'{% endif %}>
+        {% for room in day.rooms %}<room name='{{ room.name|xmlescape }}' guid='{{ room.guid }}'>
             {% for talk in room.talks %}<event guid='{{ talk.uuid }}' id='{{ talk.submission.id }}'>
                 <room>{{ room.name|xmlescape }}</room>
                 <title>{{ talk.submission.title|xmlescape }}</title>

src/pretalx/api/serializers/room.py

@@ -1,5 +1,5 @@
 from i18nfield.rest_framework import I18nAwareModelSerializer
-from rest_framework.serializers import ModelSerializer, SerializerMethodField
+from rest_framework.serializers import CharField, ModelSerializer, SerializerMethodField
 
 from pretalx.schedule.models import Availability, Room
 
@@ -17,13 +17,22 @@ class Meta:
 
 class RoomSerializer(I18nAwareModelSerializer):
     url = SerializerMethodField()
+    guid = CharField(source="uuid")
 
     def get_url(self, obj):
         return obj.urls.edit
 
     class Meta:
         model = Room
-        fields = ("id", "guid", "name", "description", "capacity", "position", "url")
+        fields = (
+            "id",
+            "guid",
+            "name",
+            "description",
+            "capacity",
+            "position",
+            "url",
+        )
 
 
 class RoomOrgaSerializer(RoomSerializer):

src/pretalx/locale/de_DE/LC_MESSAGES/django.po

@@ -7985,7 +7985,7 @@ msgstr ""
 msgid "GUID"
 msgstr "GUID"
 
-#: pretalx/schedule/models/room.py:25
+#: pretalx/schedule/models/room.py:32
 msgid "Unique identifier (UUID) to help external tools identify the room."
 msgstr ""
 "Eindeutiger Bezeichner (UUID), der externen Anwendungen hilft, diesen Raum "

src/pretalx/locale/django.pot

@@ -7042,7 +7042,7 @@ msgstr ""
 msgid "GUID"
 msgstr ""
 
-#: pretalx/schedule/models/room.py:25
+#: pretalx/schedule/models/room.py:32
 msgid "Unique identifier (UUID) to help external tools identify the room."
 msgstr ""
 

src/pretalx/schedule/exporters.py

@@ -83,7 +83,7 @@ def data(self):
             if str(talk.room.name) not in day_data["rooms"]:
                 day_data["rooms"][str(talk.room.name)] = {
                     "id": talk.room.id,
-                    "guid": talk.room.guid,
+                    "guid": talk.room.uuid,
                     "name": talk.room.name,
                     "description": talk.room.description,
                     "position": talk.room.position,
@@ -164,7 +164,7 @@ def get_data(self, **kwargs):
                 "rooms": [
                     {
                         "name": str(room.name),
-                        "guid": room.guid,
+                        "guid": room.uuid,
                         "description": str(room.description) or None,
                         "capacity": room.capacity,
                     }

src/pretalx/schedule/forms.py

@@ -217,6 +217,7 @@ def __init__(self, *args, **kwargs):
             "Information for speakers, e.g.: Projector has only HDMI input."
         )
         self.fields["capacity"].widget.attrs["placeholder"] = "300"
+        self.fields["guid"].widget.attrs["placeholder"] = self.instance.uuid or ""
 
     class Meta:
         model = Room

src/pretalx/schedule/models/room.py

@@ -1,8 +1,12 @@
+import uuid
+from functools import cached_property
+
 from django.db import models
 from django.utils.translation import gettext_lazy as _
 from i18nfield.fields import I18nCharField
 
 from pretalx.common.mixins.models import OrderedModel, PretalxModel
+from pretalx.common.models.settings import GlobalSettings
 from pretalx.common.urls import EventUrls
 
 
@@ -65,3 +69,15 @@ def __str__(self) -> str:
     @staticmethod
     def get_order_queryset(event):
         return event.rooms.all()
+
+    @cached_property
+    def uuid(self):
+        """Either a UUID5 calculated from the submission code and the instance identifier;
+        or GUID value of the room, if it was imported or set manually."""
+        if self.guid:
+            return self.guid
+
+        if not self.pk:
+            return ""
+
+        return uuid.uuid5(GlobalSettings().get_instance_identifier(), f"room:{self.pk}")