Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Review" is ambiguously used for both feedback and the process of accepting talk submissions #1449

Closed
MikkCZ opened this issue Mar 19, 2023 · 2 comments
Labels
type: bug Needs fix

Comments

@MikkCZ
Copy link
Contributor

MikkCZ commented Mar 19, 2023

Problem and impact

The term review is used in pretalx in two places - to describe the feedback process from the attendees/visitors to speakers, but also in the context of accepting/rejecting talk proposal submissions by the organization team.

The ambiguity is especially notable during localization process, and given how gettext works, there might even be the same string used for both feature, which is limiting the flexibility for locales to translate the terms differently. Which is Czech for example there is no single words that would fit in both contexts without actually increasing the ambiguity even compared to English.

Expected behaviour

I am not a native English speaker, but it would be nice to have two different terms for these two contexts. One solution that I think would be acceptable is to just go with feedback/to provide feedback instead of review in the context of giving a post-event feedback from attendees to the speakers.

Steps to reproduce

Screenshots

No response

Link

No response

Browser (software, desktop or mobile?) and version

No response

Operating system, dependency versions

No response

Version

No response

@MikkCZ MikkCZ added the type: bug Needs fix label Mar 19, 2023
@MikkCZ MikkCZ changed the title "Review" is ambiguous, used for both feedback and the process of accepting talk submissions "Review" is ambiguously used for both feedback and the process of accepting talk submissions Mar 19, 2023
@rixx
Copy link
Member

rixx commented Mar 22, 2023

I'd be happy to use clearer wording here – however, "feedback" would be just as ambiguous, as pretalx supports post-event feedback under that name.

Maybe we ought to rename the page to "preview"? As that's what it is, in the end.

@rixx
Copy link
Member

rixx commented Jul 13, 2023

If I'm not mistaken, the double meaning was only in a single place (I hope?), because I really tried to make sure that it's always "review" for organiser reviewers and "feedback" for attendees. Your issue reads like that's not the case in general, but I'm pretty sure it is?

@rixx rixx closed this as completed in 34e9784 Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Needs fix
Projects
None yet
Development

No branches or pull requests

2 participants