Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate login templates #551

Closed
vmx opened this issue Dec 15, 2018 · 1 comment
Closed

Consolidate login templates #551

vmx opened this issue Dec 15, 2018 · 1 comment
Labels
size: regular The average issue stage: up for grabs type: maintenance

Comments

@vmx
Copy link
Contributor

vmx commented Dec 15, 2018

Expected Behavior

As one of Django's design principles is DRY, it would make sense to have only a single login template.

Current Behavior

There are currently four places that provide a login form. The current templates are:

Steps to Reproduce

Look at the source :)

Context

Having a single template would adding other authentication mechanisms easier.

Your Environment
@rixx
Copy link
Member

rixx commented Feb 9, 2019

We now have a single template and a single form (and a re-used view in may places) for the login workflow!

@rixx rixx closed this as completed in f8fecba Feb 9, 2019
rixx added a commit that referenced this issue Feb 9, 2019
@rixx
Consolidate login templates, fixes #551
0c4efd3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
size: regular The average issue stage: up for grabs type: maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vmx @rixx