Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand timeslices in schedule editor on hover #1616

Closed
wants to merge 1 commit into from
Closed

Conversation

rixx
Copy link
Member

@rixx rixx commented Nov 2, 2023

This PR is very WIP and does not fully work yet. Status: Timeslices can expand on hover, but they flicker and aren't clickable.

Idea:

  • new state, tentativeExpandedSlices instead of hoverSlices, which can be made permanent with a click (adding those timeslices to the expanded slices)
  • re flickering: rash says to watch hoverSlice, but that's currently only updated when dragging, bc expensive. we could stuff that into updateHoverSlice (rename that function) and bail directly afterwards …

@rixx
Copy link
Member Author

rixx commented Feb 12, 2024

Abandoning: this is super buggy unless you do some serious observing (@mouseleave doesn't really cut it in many cases), and even if it works perfectly, the constant change in schedule size is just janky and unpleasant. I put some other ideas into the tracking issue.

@rixx rixx closed this Feb 12, 2024
@rixx rixx deleted the hover-expand branch February 12, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant