Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (#1730): Allows scheduling of pending accepted/pending confirmed talks #1732

Merged
merged 1 commit into from Apr 22, 2024

Conversation

margau
Copy link
Contributor

@margau margau commented Apr 5, 2024

This PR is a draft implementation for #1730, and allows scheduling (by creating slots) for talks that are not finally accepted/confirmed, but only pending.

This allows internal time planning for organizers while not yet having to confirm the talk.
Public visibility is not changed.

How has this been tested?

Manually tested it by moving the states forward & backward
Bildschirmfoto vom 2024-04-05 22-25-59
Bildschirmfoto vom 2024-04-05 22-26-18

Checklist

  • I have added tests to cover my changes.
  • I have updated the documentation.
  • My change is listed in the doc/changelog.rst.

Open Points/RFC

This PR, at the current stage, is intended as an RFC. Open Points:

  • in general, would you merge this feature? If yes, I'd clean/finish the PR.
  • shall we add a config option to enable this behavior? On or off by default?
  • I'm not so happy with the calls of update_talk_slots() - maybe this should be called at the end of every Submission Update to reduce complexity?

Copy link
Member

@rixx rixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I'm not sure about this. We'd need at least a way to visually distinguish these two types of sessions in the schedule editor, because otherwise, how are organisers going to know which part of their schedule is actually already set and communicated to speakers (and, potentially, the public), and which part is entirely tentative?

Currently, it's pretty clear what's going on with the regular vs striped session blocks. Once we introduce a third state, we'd need to explain what's going on, probably, so we'd need to figure out some fitting UI for that.

@margau
Copy link
Contributor Author

margau commented Apr 13, 2024

I've pushed a version (dotted border, clear text indicating the pending state) for all non-accepted or non-confirmed talks:
image

This is not relevant for talks already accepted but pending confirmation, which are shown as normal accepted talks.

What do you think about this visualization?

Copy link
Member

@rixx rixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make some small adjustments after the merge, but nothing to worry about. Thank you so much for your contribution!

@rixx rixx merged commit 2be393a into pretalx:main Apr 22, 2024
rixx added a commit that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants