Skip to content

Commit

Permalink
Payment providers: Ignore case when sorting by name
Browse files Browse the repository at this point in the history
  • Loading branch information
raphaelm committed Dec 20, 2023
1 parent 9e3ce4f commit aa121b9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/pretix/base/models/event.py
Original file line number Diff line number Diff line change
Expand Up @@ -1064,7 +1064,7 @@ def get_payment_providers(self, cached=False) -> dict:
providers[pp.identifier] = pp

self._cached_payment_providers = OrderedDict(sorted(
providers.items(), key=lambda v: (-v[1].priority, str(v[1].verbose_name))
providers.items(), key=lambda v: (-v[1].priority, str(v[1].verbose_name).title())
))
return self._cached_payment_providers

Expand Down
2 changes: 1 addition & 1 deletion src/pretix/presale/checkoutflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -1193,7 +1193,7 @@ def _total_order_value(self):
@cached_property
def provider_forms(self):
providers = []
for provider in sorted(self.request.event.get_payment_providers().values(), key=lambda p: (-p.priority, str(p.public_name))):
for provider in sorted(self.request.event.get_payment_providers().values(), key=lambda p: (-p.priority, str(p.public_name).title())):
if not provider.is_enabled or not self._is_allowed(provider, self.request):
continue
fee = provider.calculate_fee(self._total_order_value)
Expand Down
2 changes: 1 addition & 1 deletion src/pretix/presale/views/order.py
Original file line number Diff line number Diff line change
Expand Up @@ -677,7 +677,7 @@ def get(self, request, *args, **kwargs):
def provider_forms(self):
providers = []
pending_sum = self.order.pending_sum
for provider in sorted(self.request.event.get_payment_providers().values(), key=lambda p: (-p.priority, str(p.public_name))):
for provider in sorted(self.request.event.get_payment_providers().values(), key=lambda p: (-p.priority, str(p.public_name).title())):
if not provider.is_enabled:
continue

Expand Down

0 comments on commit aa121b9

Please sign in to comment.