Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow admin to change order to different products/variations #163

Closed
abrock opened this issue Aug 7, 2016 · 5 comments · Fixed by #191
Closed

Allow admin to change order to different products/variations #163

abrock opened this issue Aug 7, 2016 · 5 comments · Fixed by #191

Comments

@abrock
Copy link
Contributor

abrock commented Aug 7, 2016

Imagine someone would organize a IT-security conference where the visitors can order T-Shirts.
Suddenly a wild visitor writes an hypothetical e-mail, asking the organizers to change the (already paid) T-shirt size from "XXL" to "XL".
That should be possible as an admin.

@rixx
Copy link
Member

rixx commented Aug 7, 2016

Agreed, that would be cool.

This is a bit more tricky than it seems because variations (such as XXL and XL) are allowed to have different prices. Changing a variation to a variation of a different price would introduce a new payment cycle. So we either handle that complexity, or we make sure that only variations of the same price are allowed.

@abrock
Copy link
Contributor Author

abrock commented Aug 7, 2016

The restriction could be reduced to allowing only changes where the total price doesn't increase :-)

Or there could be a warning like "The price is going to change from X to Y, are you sure?"

@raphaelm
Copy link
Member

raphaelm commented Aug 9, 2016

They can not only be different in price, one size could already be sold out, or only be available in a given timeframe. Also, if the total changes, invoices need to change and if the payment is already paid via PayPal or Stripe, there needs to be user interaction for a partial re-payment. Then, payment fees might need to be calculated differently, ... The list goes on, this is the classic "ticket upgrade" problem :)

@abrock
Copy link
Contributor Author

abrock commented Aug 9, 2016

[... Lots of problems...]

That's all true but these are reasons why users shouldn't be able to change these things.
There are also a lot of cases where it would be convenient if the admin could just change something small like the size of the t-shirt.

@raphaelm
Copy link
Member

raphaelm commented Aug 9, 2016

There are also a lot of cases where it would be convenient if the admin could just change something small like the size of the t-shirt.

I totally see your point. This needs to be possible, absolutely. But I'm trying to figure out a way to enable admins to do this, while still preventing admins to shoot themselves into their own foot.

@raphaelm raphaelm changed the title Allow admin to edit order details like size of T-Shirt Allow admin to change order to different products/variations Aug 15, 2016
@raphaelm raphaelm mentioned this issue Aug 15, 2016
5 tasks
raphaelm added a commit that referenced this issue Aug 31, 2016
raphaelm added a commit that referenced this issue Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants